Commit4fde536

authored

fix: Improve TestSSH reliability on macOS (#3067)

Related issue:#2122

1 parent6199e6a commit4fde536Copy full SHA for 4fde536

File tree

-0

lines changed

-0

lines changed

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -91,6 +91,9 @@ func TestSSH(t *testing.T) {`
`91`	`91`
`92`	`92`	`// Shells on Mac, Windows, and Linux all exit shells with the "exit" command.`
`93`	`93`	`pty.WriteLine("exit")`
	`94`	`+// Read output to prevent hang on macOS, see:`
	`95`	`+// https://github.com/coder/coder/issues/2122`
	`96`	`+pty.ExpectMatch("exit")`
`94`	`97`	`<-cmdDone`
`95`	`98`	`})`
`96`	`99`	`t.Run("Stdio",func(t*testing.T) {`
`@@ -224,6 +227,9 @@ func TestSSH(t *testing.T) {`
`224`	`227`
`225`	`228`	`// And we're done.`
`226`	`229`	`pty.WriteLine("exit")`
	`230`	`+// Read output to prevent hang on macOS, see:`
	`231`	`+// https://github.com/coder/coder/issues/2122`
	`232`	`+pty.ExpectMatch("exit")`
`227`	`233`	`<-cmdDone`
`228`	`234`	`})`
`229`	`235`	`}`

Comments

(0)