Commit4eac2ac

authored

fix: stop reporting future licenses as errors (#14492)

1 parent5bd5801 commit4eac2acCopy full SHA for 4eac2ac

File tree

+33

-0

lines changed

+33

-0

lines changed

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -199,6 +199,13 @@ func (opts LicenseOptions) Valid(now time.Time) LicenseOptions {`
`199`	`199`	`returnopts`
`200`	`200`	`}`
`201`	`201`
	`202`	`+func (optsLicenseOptions)FutureTerm(now time.Time)LicenseOptions {`
	`203`	`+opts.NotBefore=now.Add(time.Hour*24)`
	`204`	`+opts.ExpiresAt=now.Add(time.Hour2460)`
	`205`	`+opts.GraceAt=now.Add(time.Hour2453)`
	`206`	`+returnopts`
	`207`	`+}`
	`208`	`+`
`202`	`209`	`func (optsLicenseOptions)UserLimit(limitint64)LicenseOptions {`
`203`	`210`	`returnopts.Feature(codersdk.FeatureUserLimit,limit)`
`204`	`211`	`}`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -100,6 +100,13 @@ func LicensesEntitlements(`
`100`	`100`	`// 'Entitlements' group as a whole.`
`101`	`101`	`for_,license:=rangelicenses {`
`102`	`102`	`claims,err:=ParseClaims(license.JWT,keys)`
	`103`	`+varvErr*jwt.ValidationError`
	`104`	`+ifxerrors.As(err,&vErr)&&vErr.Is(jwt.ErrTokenNotValidYet) {`
	`105`	`+// The license isn't valid yet. We don't consider any entitlements contained in it, but`
	`106`	`+// it's also not an error. Just skip it silently. This can happen if an administrator`
	`107`	`+// uploads a license for a new term that hasn't started yet.`
	`108`	`+continue`
	`109`	`+}`
`103`	`110`	`iferr!=nil {`
`104`	`111`	`entitlements.Errors=append(entitlements.Errors,`
`105`	`112`	`fmt.Sprintf("Invalid license (%s) parsing claims: %s",license.UUID.String(),err.Error()))`

Lines changed: 19 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -826,6 +826,25 @@ func TestLicenseEntitlements(t *testing.T) {`
`826`	`826`	`assert.True(t,entitlements.Features[codersdk.FeatureCustomRoles].Enabled,"custom-roles enabled for premium")`
`827`	`827`	`},`
`828`	`828`	`},`
	`829`	`+{`
	`830`	`+Name:"CurrentAndFuture",`
	`831`	`+Licenses: []*coderdenttest.LicenseOptions{`
	`832`	`+enterpriseLicense().UserLimit(100),`
	`833`	`+premiumLicense().UserLimit(200).FutureTerm(time.Now()),`
	`834`	`+},`
	`835`	`+Enablements:defaultEnablements,`
	`836`	`+AssertEntitlements:func(t*testing.T,entitlements codersdk.Entitlements) {`
	`837`	`+assertEnterpriseFeatures(t,entitlements)`
	`838`	`+assertNoErrors(t,entitlements)`
	`839`	`+assertNoWarnings(t,entitlements)`
	`840`	`+userFeature:=entitlements.Features[codersdk.FeatureUserLimit]`
	`841`	`+assert.Equalf(t,int64(100),*userFeature.Limit,"user limit")`
	`842`	`+assert.Equal(t,codersdk.EntitlementNotEntitled,`
	`843`	`+entitlements.Features[codersdk.FeatureMultipleOrganizations].Entitlement)`
	`844`	`+assert.Equal(t,codersdk.EntitlementNotEntitled,`
	`845`	`+entitlements.Features[codersdk.FeatureCustomRoles].Entitlement)`
	`846`	`+},`
	`847`	`+},`
`829`	`848`	`}`
`830`	`849`
`831`	`850`	`for_,tc:=rangetestCases {`

Comments

(0)