Commit4e6ad18

committed

refactor: use workspace names instead of UUIDs in response

Change InvalidatePrebuildsResponse.Workspaces from []uuid.UUID to []stringcontaining workspace names for better readability.

1 parentf31af9c commit4e6ad18Copy full SHA for 4e6ad18

File tree

-5

lines changed

-5

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1208,13 +1208,13 @@ func (api API) postInvalidateTemplatePrebuilds(rw http.ResponseWriter, r http.`
`1208`	`1208`	`iflen(prebuildWorkspaces)==0 {`
`1209`	`1209`	`httpapi.Write(ctx,rw,http.StatusOK, codersdk.InvalidatePrebuildsResponse{`
`1210`	`1210`	`Count:0,`
`1211`		`-Workspaces: []uuid.UUID{},`
	`1211`	`+Workspaces: []string{},`
`1212`	`1212`	`})`
`1213`	`1213`	`return`
`1214`	`1214`	`}`
`1215`	`1215`
`1216`	`1216`	`// Delete each prebuilt workspace using the existing workspace delete logic`
`1217`		`-varinvalidatedWorkspaces []uuid.UUID`
	`1217`	`+varinvalidatedWorkspaces []string`
`1218`	`1218`
`1219`	`1219`	`api.Logger.Info(ctx,"invalidating prebuilt workspaces",`
`1220`	`1220`	`slog.F("template_id",template.ID),`
`@@ -1248,7 +1248,7 @@ func (api API) postInvalidateTemplatePrebuilds(rw http.ResponseWriter, r http.`
`1248`	`1248`	`continue`
`1249`	`1249`	`}`
`1250`	`1250`
`1251`		`-invalidatedWorkspaces=append(invalidatedWorkspaces,workspace.ID)`
	`1251`	`+invalidatedWorkspaces=append(invalidatedWorkspaces,workspace.Name)`
`1252`	`1252`	`}`
`1253`	`1253`
`1254`	`1254`	`api.Logger.Info(ctx,"completed prebuild invalidation",`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -512,8 +512,8 @@ func (c *Client) StarterTemplates(ctx context.Context) ([]TemplateExample, error`
`512`	`512`	`typeInvalidatePrebuildsResponsestruct {`
`513`	`513`	`// Count is the number of prebuilt workspaces that were invalidated.`
`514`	`514`	Countint`json:"count"`
`515`		`-// Workspaces is the list of invalidated prebuilt workspaceIDs.`
`516`		-Workspaces []uuid.UUID`json:"workspaces"`
	`515`	`+// Workspaces is the list of invalidated prebuilt workspacenames.`
	`516`	+Workspaces []string`json:"workspaces"`
`517`	`517`	`}`
`518`	`518`
`519`	`519`	`// InvalidateTemplatePrebuilds invalidates all prebuilt workspaces for the`

Comments

(0)