Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit4dd5d79

Browse files
authored
fix: ParseCODER_GITAUTH_N_NO_REFRESH env var value instead of key (#7051)
1 parent3b10e89 commit4dd5d79

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

‎cli/server.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ func ReadGitAuthProvidersFromEnv(environ []string) ([]codersdk.GitAuthConfig, er
145145
case"REGEX":
146146
provider.Regex=v.Value
147147
case"NO_REFRESH":
148-
b,err:=strconv.ParseBool(key)
148+
b,err:=strconv.ParseBool(v.Value)
149149
iferr!=nil {
150150
returnnil,xerrors.Errorf("parse bool: %s",v.Value)
151151
}

‎cli/server_test.go‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ func TestReadGitAuthProvidersFromEnv(t *testing.T) {
8484
"CODER_GITAUTH_1_TOKEN_URL=google.com",
8585
"CODER_GITAUTH_1_VALIDATE_URL=bing.com",
8686
"CODER_GITAUTH_1_SCOPES=repo:read repo:write",
87+
"CODER_GITAUTH_1_NO_REFRESH=true",
8788
})
8889
require.NoError(t,err)
8990
require.Len(t,providers,2)
@@ -99,6 +100,7 @@ func TestReadGitAuthProvidersFromEnv(t *testing.T) {
99100
assert.Equal(t,"google.com",providers[1].TokenURL)
100101
assert.Equal(t,"bing.com",providers[1].ValidateURL)
101102
assert.Equal(t, []string{"repo:read","repo:write"},providers[1].Scopes)
103+
assert.Equal(t,true,providers[1].NoRefresh)
102104
})
103105
}
104106

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp