Commit4dd5d79

authored

fix: ParseCODER_GITAUTH_N_NO_REFRESH env var value instead of key (#7051)

1 parent3b10e89 commit4dd5d79Copy full SHA for 4dd5d79

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ func ReadGitAuthProvidersFromEnv(environ []string) ([]codersdk.GitAuthConfig, er`
`145`	`145`	`case"REGEX":`
`146`	`146`	`provider.Regex=v.Value`
`147`	`147`	`case"NO_REFRESH":`
`148`		`-b,err:=strconv.ParseBool(key)`
	`148`	`+b,err:=strconv.ParseBool(v.Value)`
`149`	`149`	`iferr!=nil {`
`150`	`150`	`returnnil,xerrors.Errorf("parse bool: %s",v.Value)`
`151`	`151`	`}`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,7 @@ func TestReadGitAuthProvidersFromEnv(t *testing.T) {`
`84`	`84`	`"CODER_GITAUTH_1_TOKEN_URL=google.com",`
`85`	`85`	`"CODER_GITAUTH_1_VALIDATE_URL=bing.com",`
`86`	`86`	`"CODER_GITAUTH_1_SCOPES=repo:read repo:write",`
	`87`	`+"CODER_GITAUTH_1_NO_REFRESH=true",`
`87`	`88`	`})`
`88`	`89`	`require.NoError(t,err)`
`89`	`90`	`require.Len(t,providers,2)`
`@@ -99,6 +100,7 @@ func TestReadGitAuthProvidersFromEnv(t *testing.T) {`
`99`	`100`	`assert.Equal(t,"google.com",providers[1].TokenURL)`
`100`	`101`	`assert.Equal(t,"bing.com",providers[1].ValidateURL)`
`101`	`102`	`assert.Equal(t, []string{"repo:read","repo:write"},providers[1].Scopes)`
	`103`	`+assert.Equal(t,true,providers[1].NoRefresh)`
`102`	`104`	`})`
`103`	`105`	`}`
`104`	`106`

Comments

(0)