Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit4db5158

Browse files
authored
fix: fix flaky test in WorkspacePage.test.tsx (#20033)
re-enabled the skipped test and tested locally. Passed 100 out of 100times locally.
1 parentb8370c2 commit4db5158

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

‎site/src/pages/WorkspacePage/WorkspacePage.test.tsx‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ describe("WorkspacePage", () => {
309309
// Started flaking after upgrading react-router. Tests the old parameters path
310310
// and isn't worth spending more time to fix since this code will be removed
311311
// in a few releases when dynamic parameters takes over the world.
312-
it.skip("updates the parameters when they are missing during update",async()=>{
312+
it("updates the parameters when they are missing during update",async()=>{
313313
// Mocks
314314
jest
315315
.spyOn(API,"getWorkspaceByOwnerAndName")
@@ -340,7 +340,9 @@ describe("WorkspacePage", () => {
340340

341341
// After trying to update, a new dialog asking for missed parameters should
342342
// be displayed and filled
343-
constdialog=awaitwaitFor(()=>screen.findByTestId("dialog"));
343+
constdialog=awaitscreen.findByRole("dialog",{
344+
name:/workspaceparameters/i,
345+
});
344346
constfirstParameterInput=within(dialog).getByLabelText(
345347
MockTemplateVersionParameter1.name,
346348
{exact:false},

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp