Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit4dabb5f

Browse files
committed
fix: adding loading spinners
1 parentfd75278 commit4dabb5f

File tree

4 files changed

+27
-13
lines changed

4 files changed

+27
-13
lines changed

‎site/src/pages/DeploymentSettingsPage/IdpOrgSyncPage/IdpOrgSyncPageView.tsx‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ import {
3232
MultiSelectCombobox,
3333
typeOption,
3434
}from"components/MultiSelectCombobox/MultiSelectCombobox";
35+
import{Spinner}from"components/Spinner/Spinner";
3536
import{Switch}from"components/Switch/Switch";
3637
import{useFormik}from"formik";
3738
import{Plus,SquareArrowOutUpRight,Trash}from"lucide-react";
@@ -132,6 +133,7 @@ export const IdpOrgSyncPageView: FC<IdpSyncPageViewProps> = ({
132133
form.handleSubmit();
133134
}}
134135
>
136+
<Spinnerloading={form.isSubmitting}/>
135137
Save
136138
</Button>
137139
</div>
@@ -221,7 +223,9 @@ export const IdpOrgSyncPageView: FC<IdpSyncPageViewProps> = ({
221223
setCoderOrgs([]);
222224
}}
223225
>
224-
<Plussize={14}/>
226+
<Spinnerloading={form.isSubmitting}>
227+
<Plussize={14}/>
228+
</Spinner>
225229
Add IdP organization
226230
</Button>
227231
</div>
@@ -267,6 +271,7 @@ export const IdpOrgSyncPageView: FC<IdpSyncPageViewProps> = ({
267271
}}
268272
type="submit"
269273
>
274+
<Spinnerloading={form.isSubmitting}/>
270275
Confirm
271276
</Button>
272277
</DialogFooter>
@@ -344,7 +349,7 @@ const OrganizationRow: FC<OrganizationRowProps> = ({
344349
<TableCell>
345350
<Button
346351
variant="outline"
347-
className="w-8 h-8px-1.5 py-1.5 text-content-secondary"
352+
className="w-8 h-8min-w-10 text-content-primary"
348353
aria-label="delete"
349354
onClick={()=>onDelete(idpOrg)}
350355
>

‎site/src/pages/ManagementSettingsPage/CustomRolesPage/CustomRolesPageView.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ export const CustomRolesPageView: FC<CustomRolesPageViewProps> = ({
4545
canAssignOrgRole,
4646
isCustomRolesEnabled,
4747
})=>{
48-
consttheme=useTheme();
4948
return(
5049
<Stackspacing={4}>
5150
{!isCustomRolesEnabled&&(

‎site/src/pages/ManagementSettingsPage/IdpSyncPage/IdpGroupSyncForm.tsx‎

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import {
2020
MultiSelectCombobox,
2121
typeOption,
2222
}from"components/MultiSelectCombobox/MultiSelectCombobox";
23+
import{Spinner}from"components/Spinner/Spinner";
2324
import{Switch}from"components/Switch/Switch";
2425
import{useFormik}from"formik";
2526
import{Plus,Trash}from"lucide-react";
@@ -144,6 +145,7 @@ export const IdpGroupSyncForm = ({
144145
form.handleSubmit();
145146
}}
146147
>
148+
<Spinnerloading={form.isSubmitting}/>
147149
Save
148150
</Button>
149151
</div>
@@ -154,14 +156,16 @@ export const IdpGroupSyncForm = ({
154156
</div>
155157
</div>
156158
<divclassName="flex flex-row items-center gap-3">
157-
<Switch
158-
id={AUTO_CREATE_MISSING_GROUPS_ID}
159-
checked={form.values.auto_create_missing_groups}
160-
onCheckedChange={async(checked)=>{
161-
voidform.setFieldValue("auto_create_missing_groups",checked);
162-
form.handleSubmit();
163-
}}
164-
/>
159+
<Spinnersize="sm"loading={form.isSubmitting}className="w-9">
160+
<Switch
161+
id={AUTO_CREATE_MISSING_GROUPS_ID}
162+
checked={form.values.auto_create_missing_groups}
163+
onCheckedChange={async(checked)=>{
164+
voidform.setFieldValue("auto_create_missing_groups",checked);
165+
form.handleSubmit();
166+
}}
167+
/>
168+
</Spinner>
165169
<spanclassName="flex flex-row items-center gap-1">
166170
<LabelhtmlFor={AUTO_CREATE_MISSING_GROUPS_ID}>
167171
Auto create missing groups
@@ -224,7 +228,9 @@ export const IdpGroupSyncForm = ({
224228
setCoderGroups([]);
225229
}}
226230
>
227-
<Plussize={14}/>
231+
<Spinnerloading={form.isSubmitting}>
232+
<Plussize={14}/>
233+
</Spinner>
228234
Add IdP group
229235
</Button>
230236
</div>

‎site/src/pages/ManagementSettingsPage/IdpSyncPage/IdpRoleSyncForm.tsx‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {
88
MultiSelectCombobox,
99
typeOption,
1010
}from"components/MultiSelectCombobox/MultiSelectCombobox";
11+
import{Spinner}from"components/Spinner/Spinner";
1112
import{useFormik}from"formik";
1213
import{Plus,Trash}from"lucide-react";
1314
import{typeFC,useState}from"react";
@@ -105,6 +106,7 @@ export const IdpRoleSyncForm = ({
105106
form.handleSubmit();
106107
}}
107108
>
109+
<Spinnerloading={form.isSubmitting}/>
108110
Save
109111
</Button>
110112
</div>
@@ -168,7 +170,9 @@ export const IdpRoleSyncForm = ({
168170
setCoderRoles([]);
169171
}}
170172
>
171-
<Plussize={14}/>
173+
<Spinnerloading={form.isSubmitting}>
174+
<Plussize={14}/>
175+
</Spinner>
172176
Add IdP role
173177
</Button>
174178
</div>

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp