NotificationsYou must be signed in to change notification settings
Fork927
Star10.1k

Commit49feb12

authored

chore(scripts): remove branch checks from release script (#14184)

The initial assumption that branch manipulations should be done by thisscript and not pushed to remote manually has proven to get in the way ofthe regular release flow.These are just safety-checks to prevent user error, safe to remove.Fixes#13648

1 parent89e6afb commit49feb12Copy full SHA for 49feb12

File tree

2 files changed

-10

lines changed

scripts
- release
  - tag_version.sh
- release.sh

2 files changed

-10

lines changed

`‎scripts/release.sh`

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -165,12 +165,6 @@ if [[ ${script_check} = 1 ]] && [[ -n ${script_diff} ]]; then`
`165`	`165`	`error"Release script is out-of-date. Please check out the latest version and try again."`
`166`	`166`	`fi`
`167`	`167`
`168`		`-# Make sure no other remote release contains this ref.`
`169`		`-release_contains_ref="$(git branch --remotes --contains"${ref}" --list"${remote}/release/*" --format='%(refname)')"`
`170`		`-if [[-n${release_contains_ref} ]];then`
`171`		`-error"Ref${ref_name} is already part of another release:$(git describe --always"${ref}") on${release_contains_ref#"refs/remotes/${remote}/"}."`
`172`		`-fi`
`173`		`-`
`174`	`168`	`log"Checking GitHub for latest release(s)..."`
`175`	`169`
`176`	`170`	`# Check the latest version tag from GitHub (by version) using the API.`

`‎scripts/release/tag_version.sh`

Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -171,10 +171,6 @@ else`
`171`	`171`	`fi`
`172`	`172`	`fi`
`173`	`173`
`174`		`-if [[-n${remote_branch_exists} ]];then`
`175`		`-error"Release branch${release_branch} already exists on remote, please check your ref."`
`176`		`-fi`
`177`		`-`
`178`	`174`	`if [[-n${local_branch_exists} ]];then`
`179`	`175`	`# If it exists, ensure that this release branch points to the provided ref.`
`180`	`176`	`release_branch_ref=$(git rev-parse"${release_branch}")`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit49feb12

File tree

2 files changed

2 files changed

`‎scripts/release.sh`

`‎scripts/release/tag_version.sh`

0 commit comments