Commit46146b9

committed

chore: PR fixups, renames and comments

1 parent8d594a7 commit46146b9Copy full SHA for 46146b9

File tree

+12

-7

lines changed

+12

-7

lines changed

Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,13 @@ func TagValidationError(diags hcl.Diagnostics) *DiagnosticError {`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`typeDiagnosticErrorstruct {`
`30`		`-Messagestring`
`31`		`-Diagnostics hcl.Diagnostics`
	`30`	`+// Message is the human-readable message that will be returned to the user.`
	`31`	`+Messagestring`
	`32`	`+// Diagnostics are top level diagnostics that will be returned as "Detail" in the response.`
	`33`	`+Diagnostics hcl.Diagnostics`
	`34`	`+// KeyedDiagnostics translate to Validation errors in the response. A key could`
	`35`	`+// be a parameter name, or a tag name. This allows diagnostics to be more closely`
	`36`	`+// associated with a specific index/parameter/tag.`
`32`	`37`	`KeyedDiagnosticsmap[string]hcl.Diagnostics`
`33`	`38`	`}`
`34`	`39`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,12 +6,12 @@ import (`
`6`	`6`	`"github.com/coder/coder/v2/codersdk"`
`7`	`7`	`)`
`8`	`8`
`9`		`-typeCoderSDKErrorinterface {`
	`9`	`+typeResponderinterface {`
`10`	`10`	`Response() (int, codersdk.Response)`
`11`	`11`	`}`
`12`	`12`
`13`		`-funcIsCoderSDKError(errerror) (CoderSDKError,bool) {`
`14`		`-varresponseErrCoderSDKError`
	`13`	`+funcIsResponder(errerror) (Responder,bool) {`
	`14`	`+varresponseErrResponder`
`15`	`15`	`iferrors.As(err,&responseErr) {`
`16`	`16`	`returnresponseErr,true`
`17`	`17`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ import (`
`9`	`9`	`)`
`10`	`10`
`11`	`11`	`funcWriteWorkspaceBuildError(ctx context.Context,rw http.ResponseWriter,errerror) {`
`12`		`-ifresponseErr,ok:=IsCoderSDKError(err);ok {`
	`12`	`+ifresponseErr,ok:=IsResponder(err);ok {`
`13`	`13`	`code,resp:=responseErr.Response()`
`14`	`14`
`15`	`15`	`httpapi.Write(ctx,rw,code,resp)`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1010,7 +1010,7 @@ func TestWsbuildError(t *testing.T) {`
`1010`	`1010`	`Message:msg,`
`1011`	`1011`	`}`
`1012`	`1012`
`1013`		`-respErr,ok:=httperror.IsCoderSDKError(buildErr)`
	`1013`	`+respErr,ok:=httperror.IsResponder(buildErr)`
`1014`	`1014`	`require.True(t,ok,"should be a Coder SDK error")`
`1015`	`1015`
`1016`	`1016`	`code,resp:=respErr.Response()`

Comments

(0)