Commit424579e

committed

Add test case for invalid tokens

1 parent7eb897a commit424579eCopy full SHA for 424579e

File tree

+40

-14

lines changed

+40

-14

lines changed

Lines changed: 0 additions & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -48,13 +48,6 @@ func (api API) userAuthMethods(rw http.ResponseWriter, _ http.Request) {`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`func (apiAPI)userOAuth2Github(rw http.ResponseWriter,rhttp.Request) {`
`51`		`-ifapi.GithubOAuth2Config==nil {`
`52`		`-httpapi.Write(rw,http.StatusPreconditionRequired, codersdk.Response{`
`53`		`-Message:"GitHub authentication is not enabled!",`
`54`		`-})`
`55`		`-return`
`56`		`-}`
`57`		`-`
`58`	`51`	`state:=httpmw.OAuth2(r)`
`59`	`52`
`60`	`53`	`oauthClient:=oauth2.NewClient(r.Context(),oauth2.StaticTokenSource(state.Token))`
`@@ -227,13 +220,6 @@ type OIDCConfig struct {`
`227`	`220`	`}`
`228`	`221`
`229`	`222`	`func (apiAPI)userOIDC(rw http.ResponseWriter,rhttp.Request) {`
`230`		`-ifapi.OIDCConfig==nil {`
`231`		`-httpapi.Write(rw,http.StatusPreconditionRequired, codersdk.Response{`
`232`		`-Message:"OpenID Connect authentication is not enabled!",`
`233`		`-})`
`234`		`-return`
`235`		`-}`
`236`		`-`
`237`	`223`	`state:=httpmw.OAuth2(r)`
`238`	`224`
`239`	`225`	`// See the example here: https://github.com/coreos/go-oidc`

Lines changed: 40 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -340,6 +340,46 @@ func TestUserOIDC(t *testing.T) {`
`340`	`340`	`}`
`341`	`341`	`})`
`342`	`342`	`}`
	`343`	`+`
	`344`	`+t.Run("Disabled",func(t*testing.T) {`
	`345`	`+t.Parallel()`
	`346`	`+client:=coderdtest.New(t,nil)`
	`347`	`+resp:=oidcCallback(t,client)`
	`348`	`+require.Equal(t,http.StatusPreconditionRequired,resp.StatusCode)`
	`349`	`+})`
	`350`	`+`
	`351`	`+t.Run("NoIDToken",func(t*testing.T) {`
	`352`	`+t.Parallel()`
	`353`	`+client:=coderdtest.New(t,&coderdtest.Options{`
	`354`	`+OIDCConfig:&coderd.OIDCConfig{`
	`355`	`+OAuth2Config:&oauth2Config{},`
	`356`	`+},`
	`357`	`+})`
	`358`	`+resp:=oidcCallback(t,client)`
	`359`	`+require.Equal(t,http.StatusBadRequest,resp.StatusCode)`
	`360`	`+})`
	`361`	`+`
	`362`	`+t.Run("BadVerify",func(t*testing.T) {`
	`363`	`+t.Parallel()`
	`364`	`+verifier:=oidc.NewVerifier("",&oidc.StaticKeySet{`
	`365`	`+PublicKeys: []crypto.PublicKey{},`
	`366`	`+},&oidc.Config{})`
	`367`	`+`
	`368`	`+client:=coderdtest.New(t,&coderdtest.Options{`
	`369`	`+OIDCConfig:&coderd.OIDCConfig{`
	`370`	`+OAuth2Config:&oauth2Config{`
	`371`	`+token: (&oauth2.Token{`
	`372`	`+AccessToken:"token",`
	`373`	`+}).WithExtra(map[string]interface{}{`
	`374`	`+"id_token":"invalid",`
	`375`	`+}),`
	`376`	`+},`
	`377`	`+Verifier:verifier,`
	`378`	`+},`
	`379`	`+})`
	`380`	`+resp:=oidcCallback(t,client)`
	`381`	`+require.Equal(t,http.StatusBadRequest,resp.StatusCode)`
	`382`	`+})`
`343`	`383`	`}`
`344`	`384`
`345`	`385`	`// createOIDCConfig generates a new OIDCConfig that returns a static token`

Comments

(0)