Commit3d22e27

authored

fix: handle task sidebar app health check disabled correctly (#18687)

Previously, by mistake, the task sidebar would not display workspaceapps that don't have a health check configured.

1 parent7e372f7 commit3d22e27Copy full SHA for 3d22e27

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ export const TerminatedBuildWithStatus: Story = {`
`113`	`113`	`},`
`114`	`114`	`};`
`115`	`115`
`116`		`-exportconstSidebarAppDisabled:Story={`
	`116`	`+exportconstSidebarAppHealthDisabled:Story={`
`117`	`117`	`beforeEach:()=>{`
`118`	`118`	`spyOn(data,"fetchTask").mockResolvedValue({`
`119`	`119`	`prompt:"Create competitors page",`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -54,8 +54,10 @@ const getSidebarApp = (task: Task): [WorkspaceApp \| null, SidebarAppStatus] => {`
`54`	`54`	`// indefinitely if there's a genuine issue, but this is preferable to false error alerts.`
`55`	`55`	`return[null,"loading"];`
`56`	`56`	`}`
	`57`	`+// "disabled" means that the health check is disabled, so we assume`
	`58`	`+// that the app is healthy`
`57`	`59`	`if(sidebarApp.health==="disabled"){`
`58`		`-return[sidebarApp,"error"];`
	`60`	`+return[sidebarApp,"healthy"];`
`59`	`61`	`}`
`60`	`62`	`if(sidebarApp.health==="healthy"){`
`61`	`63`	`return[sidebarApp,"healthy"];`

Comments

(0)