NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

Commit3c43216

authored

fix: remove Parallel() call after timeout context (#10203)

Fixes test flake seen here:https://github.com/coder/coder/runs/17562370632It's inherently flaky to create a context with a timeout and then later call `t.Parallel()` since it causes the test to wait until all non-parallel tests have completed before resuming execution. By the time execution has resumed, the context may have expired. The amount of time before resuming is dependent on machine resources and number of test cases, which are inherently variable.

1 parent4452a14 commit3c43216Copy full SHA for 3c43216

File tree

1 file changed

-2

lines changed

enterprise/coderd
- templates_test.go

1 file changed

-2

lines changed

`‎enterprise/coderd/templates_test.go`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -281,9 +281,8 @@ func TestTemplates(t *testing.T) {`
`281`	`281`	`for_,c:=rangecases {`
`282`	`282`	`c:=c`
`283`	`283`
	`284`	`+// nolint: paralleltest // context is from parent t.Run`
`284`	`285`	`t.Run(c.Name,func(t*testing.T) {`
`285`		`-t.Parallel()`
`286`		`-`
`287`	`286`	`_,err:=client.UpdateTemplateMeta(ctx,template.ID, codersdk.UpdateTemplateMeta{`
`288`	`287`	`Name:template.Name,`
`289`	`288`	`DisplayName:template.DisplayName,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3c43216

File tree

1 file changed

1 file changed

`‎enterprise/coderd/templates_test.go`

0 commit comments