Commit3bf7365

committed

chore: add Architecture and OperatingSystem to agent.proto

1 parentcfdea02 commit3bf7365Copy full SHA for 3bf7365

File tree

+48

-12

lines changed

+48

-12

lines changed

Lines changed: 29 additions & 8 deletions

Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -379,6 +379,8 @@ message ReportConnectionRequest {`
`379`	`379`	`messageCreateDevContainerAgentRequest {`
`380`	`380`	`stringname=1;`
`381`	`381`	`stringdirectory=2;`
	`382`	`+stringarchitecture=3;`
	`383`	`+stringoperating_system=4;`
`382`	`384`	`}`
`383`	`385`
`384`	`386`	`messageCreateDevContainerAgentResponse {`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -50,9 +50,9 @@ func (a *DevContainerAgentAPI) CreateDevContainerAgent(ctx context.Context, req`
`50`	`50`	`ResourceID:parentAgent.ResourceID,`
`51`	`51`	`AuthToken:uuid.New(),`
`52`	`52`	`AuthInstanceID:parentAgent.AuthInstanceID,`
`53`		`-Architecture:"",`
	`53`	`+Architecture:req.Architecture,`
`54`	`54`	`EnvironmentVariables: pqtype.NullRawMessage{},`
`55`		`-OperatingSystem:"",`
	`55`	`+OperatingSystem:req.OperatingSystem,`
`56`	`56`	`Directory:req.Directory,`
`57`	`57`	`InstanceMetadata: pqtype.NullRawMessage{},`
`58`	`58`	`ResourceMetadata: pqtype.NullRawMessage{},`

Lines changed: 15 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -87,12 +87,25 @@ func TestDevContainerAgentAPI(t *testing.T) {`
`87`	`87`
`88`	`88`	`// When: We create a dev container agent.`
`89`	`89`	`createResp,err:=api.CreateDevContainerAgent(ctx,&proto.CreateDevContainerAgentRequest{`
`90`		`-Name:"some-child-agent",`
`91`		`-Directory:"/workspaces/coder",`
	`90`	`+Name:"some-child-agent",`
	`91`	`+Directory:"/workspaces/coder",`
	`92`	`+Architecture:"amd64",`
	`93`	`+OperatingSystem:"linux",`
`92`	`94`	`})`
`93`	`95`	`require.NoError(t,err)`
`94`	`96`
	`97`	`+agentID,err:=uuid.FromBytes(createResp.Id)`
	`98`	`+require.NoError(t,err)`
	`99`	`+`
`95`	`100`	`// Then: We expect this dev container agent to be created.`
	`101`	`+agent,err:=api.Database.GetWorkspaceAgentByID(ctx,agentID)`
	`102`	`+require.NoError(t,err)`
	`103`	`+require.Equal(t,"/workspaces/coder",agent.Directory)`
	`104`	`+require.Equal(t,"amd64",agent.Architecture)`
	`105`	`+require.Equal(t,"linux",agent.OperatingSystem)`
	`106`	`+require.Equal(t,"some-child-agent",agent.Name)`
	`107`	`+`
	`108`	`+// Then: We expect to be able to list this dev container agent.`
`96`	`109`	`listResp,err=api.ListDevContainerAgents(ctx,&proto.ListDevContainerAgentsRequest{})`
`97`	`110`	`require.NoError(t,err)`
`98`	`111`	`require.Len(t,listResp.Agents,1)`

Comments

(0)