Commit3b36ffa

committed

fix user-activity response on no rows

1 parent4e36a62 commit3b36ffaCopy full SHA for 3b36ffa

File tree

+14

-0

lines changed

+14

-0

lines changed

Lines changed: 14 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ package coderd`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"context"`
	`5`	`+"database/sql"`
`5`	`6`	`"fmt"`
`6`	`7`	`"net/http"`
`7`	`8`	`"strings"`
`@@ -102,6 +103,19 @@ func (api API) insightsUserActivity(rw http.ResponseWriter, r http.Request) {`
`102`	`103`	`TemplateIDs:templateIDs,`
`103`	`104`	`})`
`104`	`105`	`iferr!=nil {`
	`106`	`+// No data is not an error.`
	`107`	`+ifxerrors.Is(err,sql.ErrNoRows) {`
	`108`	`+httpapi.Write(ctx,rw,http.StatusOK, codersdk.UserActivityInsightsResponse{`
	`109`	`+Report: codersdk.UserActivityInsightsReport{`
	`110`	`+StartTime:startTime,`
	`111`	`+EndTime:endTime,`
	`112`	`+TemplateIDs: []uuid.UUID{},`
	`113`	`+Users: []codersdk.UserActivity{},`
	`114`	`+},`
	`115`	`+})`
	`116`	`+return`
	`117`	`+}`
	`118`	`+// Check authorization.`
`105`	`119`	`ifhttpapi.Is404Error(err) {`
`106`	`120`	`httpapi.ResourceNotFound(rw)`
`107`	`121`	`return`

Comments

(0)