Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit38b21ab

Browse files
authored
fix(site): gracefully handle reselection of the same preset (#17014)
This PRcloses#16953.Reselecting a preset that was already the selected preset returned anundefined option to the onSelect function. We then tried to read anattribute of this undefined value. With this fix, we handle theundefined option correctly.
1 parentb39477c commit38b21ab

File tree

2 files changed

+25
-4
lines changed

2 files changed

+25
-4
lines changed

‎site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,25 @@ export const PresetSelected: Story = {
159159
},
160160
};
161161

162+
exportconstPresetReselected:Story={
163+
args:PresetsButNoneSelected.args,
164+
play:async({ canvasElement})=>{
165+
constcanvas=within(canvasElement);
166+
167+
// First selection of Preset 1
168+
awaituserEvent.click(canvas.getByLabelText("Preset"));
169+
awaituserEvent.click(
170+
canvas.getByText("Preset 1",{selector:".MuiMenuItem-root"}),
171+
);
172+
173+
// Reselect the same preset
174+
awaituserEvent.click(canvas.getByLabelText("Preset"));
175+
awaituserEvent.click(
176+
canvas.getByText("Preset 1",{selector:".MuiMenuItem-root"}),
177+
);
178+
},
179+
};
180+
162181
exportconstExternalAuth:Story={
163182
args:{
164183
externalAuth:[

‎site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -286,11 +286,13 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({
286286
label="Preset"
287287
options={presetOptions}
288288
onSelect={(option)=>{
289-
setSelectedPresetIndex(
290-
presetOptions.findIndex(
291-
(preset)=>preset.value===option?.value,
292-
),
289+
constindex=presetOptions.findIndex(
290+
(preset)=>preset.value===option?.value,
293291
);
292+
if(index===-1){
293+
return;
294+
}
295+
setSelectedPresetIndex(index);
294296
}}
295297
placeholder="Select a preset"
296298
selectedOption={presetOptions[selectedPresetIndex]}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp