Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit38028df

Browse files
ci: make test-go-pg-17 a required check (#19722)
We run an additional test suite with the latest major version of Postgres. Until now, it hasn't been required that this suite pass before merging, prior discussion available [here](#13665 (comment)). Making it required also means we'll receive slack notifications when it fails on `main`.
1 parentd25ff6c commit38028df

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

‎.github/workflows/ci.yaml‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -531,9 +531,6 @@ jobs:
531531
with:
532532
api-key:${{ secrets.DATADOG_API_KEY }}
533533

534-
# NOTE: this could instead be defined as a matrix strategy, but we want to
535-
# only block merging if tests on postgres 13 fail. Using a matrix strategy
536-
# here makes the check in the above `required` job rather complicated.
537534
test-go-pg-17:
538535
runs-on:${{ github.repository_owner == 'coder' && 'depot-ubuntu-22.04-8' || 'ubuntu-latest' }}
539536
needs:
@@ -926,6 +923,7 @@ jobs:
926923
-lint
927924
-gen
928925
-test-go-pg
926+
-test-go-pg-17
929927
-test-go-race-pg
930928
-test-js
931929
-test-e2e
@@ -948,6 +946,7 @@ jobs:
948946
echo "- lint: ${{ needs.lint.result }}"
949947
echo "- gen: ${{ needs.gen.result }}"
950948
echo "- test-go-pg: ${{ needs.test-go-pg.result }}"
949+
echo "- test-go-pg-17: ${{ needs.test-go-pg-17.result }}"
951950
echo "- test-go-race-pg: ${{ needs.test-go-race-pg.result }}"
952951
echo "- test-js: ${{ needs.test-js.result }}"
953952
echo "- test-e2e: ${{ needs.test-e2e.result }}"

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp