NotificationsYou must be signed in to change notification settings
Fork909
Star10k

Commit36d938f

authored

fix: show diagnostics if there are no parameters (#17967)

Prefer to show the top level diagnostics inside the parameters sectionfor context but this adds a case to show diagnostics if there are noparameters.Normally, the entire parameters section is hidden if there are noparameters.

1 parentb7462fb commit36d938fCopy full SHA for 36d938f

File tree

1 file changed

-0

lines changed

site/src/pages/CreateWorkspacePage
- CreateWorkspacePageViewExperimental.tsx

1 file changed

-0

lines changed

`‎site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -489,6 +489,10 @@ export const CreateWorkspacePageViewExperimental: FC<`
`489`	`489`	`</section>`
`490`	`490`	`)}`
`491`	`491`
	`492`	`+{parameters.length===0&&diagnostics.length>0&&(`
	`493`	`+<Diagnosticsdiagnostics={diagnostics}/>`
	`494`	`+)}`
	`495`	`+`
`492`	`496`	`{parameters.length>0&&(`
`493`	`497`	`<sectionclassName="flex flex-col gap-9">`
`494`	`498`	`<hgroup>`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit36d938f

File tree

1 file changed

1 file changed

`‎site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx`

0 commit comments