Commit36d7d39

committed

wording

1 parentf13df6f commit36d7d39Copy full SHA for 36d7d39

File tree

+14

-4

lines changed

+14

-4

lines changed

Lines changed: 10 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ func githubRateLimits(resp *http.Response, err error) (rateLimits, bool) {`
`28`	`28`	`Limit:p.int("x-ratelimit-limit"),`
`29`	`29`	`Remaining:p.int("x-ratelimit-remaining"),`
`30`	`30`	`Used:p.int("x-ratelimit-used"),`
`31`		`-Resource:p.header.Get("x-ratelimit-resource"),`
	`31`	`+Resource:p.string("x-ratelimit-resource"),`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`iflimits.Limit==0&&`
`@@ -74,7 +74,7 @@ type headerParser struct {`
`74`	`74`	`header http.Header`
`75`	`75`	`}`
`76`	`76`
`77`		`-func (p*headerParser)int(keystring)int {`
	`77`	`+func (p*headerParser)string(keystring)string {`
`78`	`78`	`ifp.errors==nil {`
`79`	`79`	`p.errors=make(map[string]error)`
`80`	`80`	`}`
`@@ -83,6 +83,14 @@ func (p *headerParser) int(key string) int {`
`83`	`83`	`ifv=="" {`
`84`	`84`	`p.errors[key]=fmt.Errorf("missing header %q",key)`
`85`	`85`	`}`
	`86`	`+returnv`
	`87`	`+}`
	`88`	`+`
	`89`	`+func (p*headerParser)int(keystring)int {`
	`90`	`+v:=p.string(key)`
	`91`	`+ifv=="" {`
	`92`	`+return-1`
	`93`	`+}`
`86`	`94`
`87`	`95`	`i,err:=strconv.Atoi(v)`
`88`	`96`	`iferr!=nil {`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -50,9 +50,11 @@ type metrics struct {`
`50`	`50`	`rateLimit*prometheus.GaugeVec`
`51`	`51`	`rateLimitRemaining*prometheus.GaugeVec`
`52`	`52`	`rateLimitUsed*prometheus.GaugeVec`
`53`		`-// rateLimitReset isthe timein secondsthe rate limit resets.`
	`53`	`+// rateLimitReset isunix timeof the next interval (whenthe rate limit resets).`
`54`	`54`	`rateLimitReset*prometheus.GaugeVec`
`55`	`55`	`// rateLimitResetIn is the time in seconds until the rate limit resets.`
	`56`	`+// This is included because it is sometimes more helpful to know the limit`
	`57`	`+// will reset in 600seconds, rather than at 1704000000 unix time.`
`56`	`58`	`rateLimitResetIn*prometheus.GaugeVec`
`57`	`59`	`}`
`58`	`60`
`@@ -104,7 +106,7 @@ func NewFactory(registry prometheus.Registerer) *Factory {`
`104`	`106`	`Namespace:"coderd",`
`105`	`107`	`Subsystem:"oauth2",`
`106`	`108`	`Name:"external_requests_rate_limit_next_reset_unix",`
`107`		`-Help:"Unix timestampofthe next interval",`
	`109`	`+Help:"Unix timestampfor whenthe next interval starts",`
`108`	`110`	`}, []string{`
`109`	`111`	`"name",`
`110`	`112`	`"resource",`

Comments

(0)