Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit369cb18

Browse files
committed
fix: allow startup scripts larger than 32k
1 parent4d63a47 commit369cb18

File tree

2 files changed

+49
-0
lines changed

2 files changed

+49
-0
lines changed

‎coderd/workspaceagentsrpc_test.go

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
package coderd_test
2+
3+
import (
4+
"context"
5+
"testing"
6+
7+
"github.com/stretchr/testify/require"
8+
9+
agentproto"github.com/coder/coder/v2/agent/proto"
10+
"github.com/coder/coder/v2/coderd/coderdtest"
11+
"github.com/coder/coder/v2/coderd/database"
12+
"github.com/coder/coder/v2/coderd/database/dbfake"
13+
"github.com/coder/coder/v2/codersdk/agentsdk"
14+
"github.com/coder/coder/v2/provisionersdk/proto"
15+
)
16+
17+
funcTestAgentAPI_LargeManifest(t*testing.T) {
18+
t.Parallel()
19+
ctx:=context.Background()
20+
client,store:=coderdtest.NewWithDatabase(t,nil)
21+
adminUser:=coderdtest.CreateFirstUser(t,client)
22+
n:=512000
23+
longScript:=make([]byte,n)
24+
fori:=rangelongScript {
25+
longScript[i]='q'
26+
}
27+
r:=dbfake.WorkspaceBuild(t,store, database.Workspace{
28+
OrganizationID:adminUser.OrganizationID,
29+
OwnerID:adminUser.UserID,
30+
}).WithAgent(func(agents []*proto.Agent) []*proto.Agent {
31+
agents[0].Scripts= []*proto.Script{
32+
{
33+
Script:string(longScript),
34+
},
35+
}
36+
returnagents
37+
}).Do()
38+
ac:=agentsdk.New(client.URL)
39+
ac.SetSessionToken(r.AgentToken)
40+
conn,err:=ac.ConnectRPC(ctx)
41+
deferconn.Close()
42+
require.NoError(t,err)
43+
agentAPI:=agentproto.NewDRPCAgentClient(conn)
44+
manifest,err:=agentAPI.GetManifest(ctx,&agentproto.GetManifestRequest{})
45+
require.NoError(t,err)
46+
require.Len(t,manifest.Scripts,1)
47+
require.Len(t,manifest.Scripts[0].Script,n)
48+
}

‎codersdk/agentsdk/agentsdk.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,7 @@ func (c *Client) ConnectRPC(ctx context.Context) (drpc.Conn, error) {
202202
}
203203
returnnil,codersdk.ReadBodyAsError(res)
204204
}
205+
conn.SetReadLimit(1<<22)// 4 MiB -- about the limit for protobufs
205206

206207
_,wsNetConn:=websocketNetConn(ctx,conn,websocket.MessageBinary)
207208

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp