Commit3650ef1

committed

fix(site): show error on template upload failure

1 parentaa0dc2d commit3650ef1Copy full SHA for 3650ef1

File tree

+45

-2

lines changed

+45

-2

lines changed

Lines changed: 35 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,8 @@`
`1`		`-import{screen,waitFor,within}from"@testing-library/react";`
	`1`	`+import{fireEvent,screen,waitFor,within}from"@testing-library/react";`
`2`	`2`	`importuserEventfrom"@testing-library/user-event";`
`3`	`3`	`import{API}from"api/api";`
`4`	`4`	`import{`
	`5`	`+mockApiError,`
`5`	`6`	`MockTemplate,`
`6`	`7`	`MockTemplateExample,`
`7`	`8`	`MockTemplateVersion,`
`@@ -150,3 +151,36 @@ test("Create template from duplicating a template", async () => {`
`150`	`151`	`);`
`151`	`152`	`});`
`152`	`153`	`});`
	`154`	`+`
	`155`	`+test("The page displays an error if the upload fails",async()=>{`
	`156`	+consterrMsg=`Unsupported content type header`
	`157`	`+jest.spyOn(API,"uploadFile").mockRejectedValueOnce(`
	`158`	`+mockApiError({`
	`159`	`+message:errMsg,`
	`160`	`+}),`
	`161`	`+);`
	`162`	`+awaitrenderPage(newURLSearchParams());`
	`163`	`+`
	`164`	`+constfile=newFile([""],"invalidfile.tar");`
	`165`	`+constdropZone=screen.getByTestId("drop-zone");`
	`166`	`+`
	`167`	`+fireEvent.drop(dropZone,{`
	`168`	`+dataTransfer:{files:[file]},`
	`169`	`+});`
	`170`	`+`
	`171`	`+awaitwaitFor(()=>expect(API.uploadFile).toHaveBeenCalledTimes(1));`
	`172`	`+`
	`173`	`+// Error toast should be displayed`
	`174`	`+expect(`
	`175`	`+awaitscreen.findByText(`
	`176`	`+errMsg,`
	`177`	`+),`
	`178`	`+).toBeInTheDocument();`
	`179`	`+`
	`180`	`+// The upload box should have reset itself`
	`181`	`+expect(`
	`182`	`+awaitscreen.findByText(`
	`183`	`+/Thetemplatehastobea.taror.zipfile/,`
	`184`	`+),`
	`185`	`+).toBeInTheDocument();`
	`186`	`+});`

Lines changed: 10 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,8 @@ import { useNavigate } from "react-router-dom";`
`12`	`12`	`import{CreateTemplateForm}from"./CreateTemplateForm";`
`13`	`13`	`importtype{CreateTemplatePageViewProps}from"./types";`
`14`	`14`	`import{firstVersionFromFile,getFormPermissions,newTemplate}from"./utils";`
	`15`	`+import{displayError}from"components/GlobalSnackbar/utils";`
	`16`	`+import{getErrorMessage}from"api/errors";`
`15`	`17`
`16`	`18`	`exportconstUploadTemplateView:FC<CreateTemplatePageViewProps>=({`
`17`	`19`	`onCreateTemplate,`
`@@ -51,7 +53,14 @@ export const UploadTemplateView: FC<CreateTemplatePageViewProps> = ({`
`51`	`53`	`jobError={isJobError ?error.job.error :undefined}`
`52`	`54`	`logs={templateVersionLogsQuery.data}`
`53`	`55`	`upload={{`
`54`		`-onUpload:uploadFileMutation.mutateAsync,`
	`56`	`+onUpload:async(file:File)=>{`
	`57`	`+try{`
	`58`	`+awaituploadFileMutation.mutateAsync(file);`
	`59`	`+}catch(error){`
	`60`	`+displayError(getErrorMessage(error,"Failed to upload file"));`
	`61`	`+uploadFileMutation.reset()`
	`62`	`+}`
	`63`	`+},`
`55`	`64`	`isUploading:uploadFileMutation.isLoading,`
`56`	`65`	`onRemove:uploadFileMutation.reset,`
`57`	`66`	`file:uploadFileMutation.variables,`

Comments

(0)