Commit313d4e0

authored

chore(scaletest/dashboard): stub out initChromeDPCtx in unit tests (#13650)

1 parent65b9f9b commit313d4e0Copy full SHA for 313d4e0

File tree

+14

-1

lines changed

+14

-1

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ package dashboard`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"context"`
	`5`	`+"net/url"`
`5`	`6`	`"time"`
`6`	`7`
`7`	`8`	`"cdr.dev/slog"`
`@@ -28,6 +29,8 @@ type Config struct {`
`28`	`29`	`Screenshotfunc(ctx context.Context,filenamestring) (string,error)`
`29`	`30`	`// RandIntn is a function that returns a random number between 0 and n-1.`
`30`	`31`	RandIntnfunc(int)int`json:"-"`
	`32`	`+// InitChromeDPCtx is a function that initializes ChromeDP into the given context.Context.`
	`33`	+InitChromeDPCtxfunc(ctx context.Context,log slog.Logger,u*url.URL,sessionTokenstring,headlessbool) (context.Context, context.CancelFunc,error)`json:"-"`
`31`	`34`	`}`
`32`	`35`
`33`	`36`	`func (cConfig)Validate()error {`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,9 @@ func NewRunner(client codersdk.Client, metrics Metrics, cfg Config) Runner {`
`39`	`39`	`ifcfg.RandIntn==nil {`
`40`	`40`	`cfg.RandIntn=rand.Intn`
`41`	`41`	`}`
	`42`	`+ifcfg.InitChromeDPCtx==nil {`
	`43`	`+cfg.InitChromeDPCtx=initChromeDPCtx`
	`44`	`+}`
`42`	`45`	`return&Runner{`
`43`	`46`	`client:client,`
`44`	`47`	`cfg:cfg,`
`@@ -70,7 +73,7 @@ func (r *Runner) runUntilDeadlineExceeded(ctx context.Context) error {`
`70`	`73`	`returnxerrors.Errorf("user has no organizations")`
`71`	`74`	`}`
`72`	`75`
`73`		`-cdpCtx,cdpCancel,err:=initChromeDPCtx(ctx,r.cfg.Logger,r.client.URL,r.client.SessionToken(),r.cfg.Headless)`
	`76`	`+cdpCtx,cdpCancel,err:=r.cfg.InitChromeDPCtx(ctx,r.cfg.Logger,r.client.URL,r.client.SessionToken(),r.cfg.Headless)`
`74`	`77`	`iferr!=nil {`
`75`	`78`	`returnxerrors.Errorf("init chromedp ctx: %w",err)`
`76`	`79`	`}`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@ package dashboard_test`
`3`	`3`	`import (`
`4`	`4`	`"context"`
`5`	`5`	`"math/rand"`
	`6`	`+"net/url"`
`6`	`7`	`"runtime"`
`7`	`8`	`"sync"`
`8`	`9`	`"sync/atomic"`
`@@ -52,6 +53,7 @@ func Test_Run(t *testing.T) {`
`52`	`53`	`waitLoadedCalled atomic.Bool`
`53`	`54`	`screenshotCalled atomic.Bool`
`54`	`55`	`)`
	`56`	`+cancelDone:=make(chanstruct{})`
`55`	`57`	`cfg:= dashboard.Config{`
`56`	`58`	`Interval:500*time.Millisecond,`
`57`	`59`	`Jitter:100*time.Millisecond,`
`@@ -72,6 +74,9 @@ func Test_Run(t *testing.T) {`
`72`	`74`	`return"/fake/path/to/"+name+".png",nil`
`73`	`75`	`},`
`74`	`76`	`RandIntn:rg.Intn,`
	`77`	`+InitChromeDPCtx:func(ctx context.Context,_ slog.Logger,_*url.URL,_string,_bool) (context.Context, context.CancelFunc,error) {`
	`78`	`+returnctx,func() {close(cancelDone) },nil`
	`79`	`+},`
`75`	`80`	`}`
`76`	`81`	`r:=dashboard.NewRunner(client,m,cfg)`
`77`	`82`	`ctx,cancel:=context.WithTimeout(context.Background(),testutil.WaitShort)`
`@@ -84,6 +89,8 @@ func Test_Run(t *testing.T) {`
`84`	`89`	`err,ok:=<-done`
`85`	`90`	`assert.True(t,ok)`
`86`	`91`	`require.NoError(t,err)`
	`92`	`+_,ok=<-cancelDone`
	`93`	`+require.False(t,ok,"cancel should have been called")`
`87`	`94`
`88`	`95`	`for_,dur:=rangem.ObservedDurations["succeeds"] {`
`89`	`96`	`assert.NotZero(t,dur)`

Comments

(0)