Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit2ec9be2

Browse files
authored
fix: only show error once when failing to update org member roles (#20155)
1 parentb48e367 commit2ec9be2

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

‎site/src/pages/OrganizationSettingsPage/OrganizationMembersPageView.tsx‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -149,14 +149,12 @@ export const OrganizationMembersPageView: FC<
149149
isLoading={isUpdatingMemberRoles}
150150
canEditUsers={canEditMembers}
151151
onEditRoles={async(roles)=>{
152+
// React doesn't mind uncaught errors in event handlers,
153+
// but testing-library does.
152154
try{
153155
awaitupdateMemberRoles(member,roles);
154156
displaySuccess("Roles updated successfully.");
155-
}catch(error){
156-
displayError(
157-
getErrorMessage(error,"Failed to update roles."),
158-
);
159-
}
157+
}catch{}
160158
}}
161159
/>
162160
<UserGroupsCelluserGroups={member.groups}/>

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp