NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

Commit2cb9bfd

authored

refactor(coderd): move healthcheck report structs to codersdk (#12279)

Moves healthcheck report-related structs from coderd/healthcheck to codersdkThis prevents an import cycle when adding a codersdk.Client method to hit /api/v2/debug/health.

1 parentaa7a9f5 commit2cb9bfdCopy full SHA for 2cb9bfd

File tree

21 files changed

+5555

-5539

lines changed

cli
- netcheck_test.go
coderd
- apidoc
  - docs.go
  - swagger.json
- coderd.go
- coderdtest
  - coderdtest.go
- debug.go
- debug_test.go
- healthcheck
codersdk
- health.go
docs/api
- debug.md
- schemas.md
scripts/apitypings
- main.go
site/src/api
- typesGenerated.ts

21 files changed

+5555

-5539

lines changed

`‎cli/netcheck_test.go`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ import (`
`9`	`9`	`"github.com/stretchr/testify/require"`
`10`	`10`
`11`	`11`	`"github.com/coder/coder/v2/cli/clitest"`
`12`		`-"github.com/coder/coder/v2/coderd/healthcheck/derphealth"`
	`12`	`+"github.com/coder/coder/v2/codersdk"`
`13`	`13`	`"github.com/coder/coder/v2/pty/ptytest"`
`14`	`14`	`)`
`15`	`15`
`@@ -27,7 +27,7 @@ func TestNetcheck(t *testing.T) {`
`27`	`27`
`28`	`28`	`b:=out.Bytes()`
`29`	`29`	`t.Log(string(b))`
`30`		`-varreportderphealth.Report`
	`30`	`+varreportcodersdk.DERPHealthReport`
`31`	`31`	`require.NoError(t,json.Unmarshal(b,&report))`
`32`	`32`
`33`	`33`	`assert.True(t,report.Healthy)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2cb9bfd

File tree

21 files changed

21 files changed

`‎cli/netcheck_test.go`

0 commit comments