NotificationsYou must be signed in to change notification settings
Fork914
Star10.1k

Commit2aa749a

authored

chore(cli): fix test flake caused by agent connect race (#16725)

Fixes test flake seen here:https://github.com/coder/coder/actions/runs/13552012547/job/37877778883``` exp_rpty_test.go:96: Error Trace:/home/runner/work/coder/coder/cli/exp_rpty_test.go:96 /home/runner/work/coder/coder/cli/ssh_test.go:1963 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.9.linux-amd64/src/runtime/asm_amd64.s:1695 Error: Received unexpected error: running command "coder exp rpty": GET http://localhost:37991/api/v2/workspaceagents/3785b98f-0589-47d2-a3c8-33a55a6c5b29/containers: unexpected status code 400: Agent state is "connecting", it must be in the "connected" state. Test: TestExpRpty/Container```

1 parent81ef9e9 commit2aa749aCopy full SHA for 2aa749a

File tree

1 file changed

-5

lines changed

cli
- exp_rpty_test.go

1 file changed

-5

lines changed

`‎cli/exp_rpty_test.go`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,11 @@ func TestExpRpty(t *testing.T) {`
`87`	`87`	`require.NoError(t,err,"Could not stop container")`
`88`	`88`	`})`
`89`	`89`
	`90`	`+_=agenttest.New(t,client.URL,agentToken,func(o*agent.Options) {`
	`91`	`+o.ExperimentalContainersEnabled=true`
	`92`	`+})`
	`93`	`+_=coderdtest.NewWorkspaceAgentWaiter(t,client,workspace.ID).Wait()`
	`94`	`+`
`90`	`95`	`inv,root:=clitest.New(t,"exp","rpty",workspace.Name,"-c",ct.Container.ID)`
`91`	`96`	`clitest.SetupConfig(t,client,root)`
`92`	`97`	`pty:=ptytest.New(t).Attach(inv)`
`@@ -96,11 +101,6 @@ func TestExpRpty(t *testing.T) {`
`96`	`101`	`assert.NoError(t,err)`
`97`	`102`	`})`
`98`	`103`
`99`		`-_=agenttest.New(t,client.URL,agentToken,func(o*agent.Options) {`
`100`		`-o.ExperimentalContainersEnabled=true`
`101`		`-})`
`102`		`-_=coderdtest.NewWorkspaceAgentWaiter(t,client,workspace.ID).Wait()`
`103`		`-`
`104`	`104`	`pty.ExpectMatch(fmt.Sprintf("Connected to %s",workspace.Name))`
`105`	`105`	`pty.ExpectMatch("Reconnect ID: ")`
`106`	`106`	`pty.ExpectMatch(" #")`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2aa749a

File tree

1 file changed

1 file changed

`‎cli/exp_rpty_test.go`

0 commit comments