Commit2851d9f

authored

fix: return empty array if no option multi-selected (#19224)

Related:#19145

1 parent91780db commit2851d9fCopy full SHA for 2851d9f

File tree

+16

-1

lines changed

+16

-1

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -349,7 +349,11 @@ func RichMultiSelect(inv *serpent.Invocation, richOptions RichMultiSelectOptions`
`349`	`349`	`}`
`350`	`350`
`351`	`351`	`// Check selected option, convert descriptions (line) to values`
`352`		`-varresults []string`
	`352`	`+//`
	`353`	`+// The function must return an initialized empty array, since it is later marshaled`
	`354`	+// into JSON. Otherwise, `var results []string` would be marshaled to "null".
	`355`	`+// See: https://github.com/golang/go/issues/27589`
	`356`	`+results:= []string{}`
`353`	`357`	`for_,sel:=rangeselected {`
`354`	`358`	`custom:=true`
`355`	`359`	`fori,option:=rangerichOptions.Options {`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -111,6 +111,17 @@ func TestRichMultiSelect(t *testing.T) {`
`111`	`111`	`allowCustom:true,`
`112`	`112`	`want: []string{"aaa","bbb"},`
`113`	`113`	`},`
	`114`	`+{`
	`115`	`+name:"NoOptionSelected",`
	`116`	`+options: []codersdk.TemplateVersionParameterOption{`
	`117`	`+{Name:"AAA",Description:"This is AAA",Value:"aaa"},`
	`118`	`+{Name:"BBB",Description:"This is BBB",Value:"bbb"},`
	`119`	`+{Name:"CCC",Description:"This is CCC",Value:"ccc"},`
	`120`	`+},`
	`121`	`+defaults: []string{},`
	`122`	`+allowCustom:false,`
	`123`	`+want: []string{},`
	`124`	`+},`
`114`	`125`	`}`
`115`	`126`
`116`	`127`	`for_,tt:=rangetests {`

Comments

(0)