Commit26490ae

authored

chore: improve postgres test time by removing cleanup (#7522)

We don't need to delete databases on cleanup... and we don't need toalways run without a cache either!

1 parent778cb74 commit26490aeCopy full SHA for 26490ae

File tree

-9

lines changed

-9

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -608,9 +608,8 @@ test-postgres: test-clean test-postgres-docker`
`608`	`608`	`--jsonfile="gotests.json"\`
`609`	`609`	`--packages="./..." --\`
`610`	`610`	`-covermode=atomic -coverprofile="gotests.coverage" -timeout=20m\`
`611`		`--parallel=4\`
`612`	`611`	`-coverpkg=./...\`
`613`		`--count=1 -race -failfast`
	`612`	`+-race -failfast`
`614`	`613`	`.PHONY: test-postgres`
`615`	`614`
`616`	`615`	`test-postgres-docker:`
`@@ -627,6 +626,8 @@ test-postgres-docker:`
`627`	`626`	`--detach\`
`628`	`627`	`postgres:13\`
`629`	`628`	`-c shared_buffers=1GB\`
	`629`	`+-c work_mem=1GB\`
	`630`	`+-c effective_cache_size=1GB\`
`630`	`631`	`-c max_connections=1000\`
`631`	`632`	`-c fsync=off\`
`632`	`633`	`-c synchronous_commit=off\`

Lines changed: 4 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -46,13 +46,10 @@ func Open() (string, func(), error) {`
`46`	`46`	`return"",nil,xerrors.Errorf("create db with template: %w",err)`
`47`	`47`	`}`
`48`	`48`
`49`		`-deleteDB:=func() {`
`50`		`-ddb,_:=sql.Open("postgres",dbURL)`
`51`		`-deferddb.Close()`
`52`		`-_,_=ddb.Exec("DROP DATABASE "+dbName)`
`53`		`-}`
`54`		`-`
`55`		`-return"postgres://postgres:postgres@127.0.0.1:5432/"+dbName+"?sslmode=disable",deleteDB,nil`
	`49`	`+return"postgres://postgres:postgres@127.0.0.1:5432/"+dbName+"?sslmode=disable",func() {`
	`50`	`+// We don't need to clean anything up here... it's just a database in a container,`
	`51`	`+// so cleaning up the container will clean up the database.`
	`52`	`+},nil`
`56`	`53`	`}`
`57`	`54`
`58`	`55`	`pool,err:=dockertest.NewPool("")`

Comments

(0)