NotificationsYou must be signed in to change notification settings
Fork906
Star10k

Commit25ead7b

committed

feat(agent/agentcontainers): update containers periodically

This change introduces a significant refactor to the agentcontainers APIand enabled periodic updates of Docker containers rather than on-demand.Consequently this change also allows us to move away from using alocking channel and replace it with a mutex, which simplifies usage.Additionally a previous oversight was fixed, and testing added, to cleardevcontainer running/dirty status when the container has been removed.Updates#16424Updatescoder/internal#621

1 parent98e2ec4 commit25ead7bCopy full SHA for 25ead7b

File tree

5 files changed

+467

-327

lines changed

agent
- agent.go
- agentcontainers
  - api.go
  - api_test.go
cli
- ssh_test.go
coderd
- workspaceagents_test.go

5 files changed

+467

-327

lines changed

`‎agent/agent.go`

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1176,12 +1176,6 @@ func (a agent) handleManifest(manifestOK checkpoint) func(ctx context.Context,`
`1176`	`1176`	`}`
`1177`	`1177`	`a.metrics.startupScriptSeconds.WithLabelValues(label).Set(dur)`
`1178`	`1178`	`a.scriptRunner.StartCron()`
`1179`		`-ifcontainerAPI:=a.containerAPI.Load();containerAPI!=nil {`
`1180`		`-// Inform the container API that the agent is ready.`
`1181`		`-// This allows us to start watching for changes to`
`1182`		`-// the devcontainer configuration files.`
`1183`		`-containerAPI.SignalReady()`
`1184`		`-}`
`1185`	`1179`	`})`
`1186`	`1180`	`iferr!=nil {`
`1187`	`1181`	`returnxerrors.Errorf("track conn goroutine: %w",err)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit25ead7b

File tree

5 files changed

5 files changed

`‎agent/agent.go`

0 commit comments