Commit254a5b6

committed

Add constant for JetBrains magic string

1 parent4d65478 commit254a5b6Copy full SHA for 254a5b6

File tree

-4

lines changed

-4

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -47,8 +47,12 @@ const (`
`47`	`47`	`MagicSessionTypeEnvironmentVariable="CODER_SSH_SESSION_TYPE"`
`48`	`48`	`// MagicSessionTypeVSCode is set in the SSH config by the VS Code extension to identify itself.`
`49`	`49`	`MagicSessionTypeVSCode="vscode"`
`50`		`-// MagicSessionTypeJetBrains is set in the SSH config by the JetBrains extension to identify itself.`
	`50`	`+// MagicSessionTypeJetBrains is set in the SSH config by the JetBrains`
	`51`	`+// extension to identify itself.`
`51`	`52`	`MagicSessionTypeJetBrains="jetbrains"`
	`53`	`+// MagicProcessCmdlineJetBrains is a string in a process's command line that`
	`54`	`+// uniquely identifies it as JetBrains software.`
	`55`	`+MagicProcessCmdlineJetBrains="idea.vendor.name=JetBrains"`
`52`	`56`	`)`
`53`	`57`
`54`	`58`	`typeServerstruct {`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -46,9 +46,8 @@ func NewJetbrainsChannelWatcher(ctx ssh.Context, logger slog.Logger, newChannel`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`// If this is not JetBrains, then we do not need to do anything special. We`
`49`		`-// attempt to match on something that appears unique to JetBrains software and`
`50`		`-// the vendor name flag seems like it might be a reasonable choice.`
`51`		`-if!strings.Contains(strings.ToLower(cmdline),"idea.vendor.name=jetbrains") {`
	`49`	`+// attempt to match on something that appears unique to JetBrains software.`
	`50`	`+if!strings.Contains(strings.ToLower(cmdline),strings.ToLower(MagicProcessCmdlineJetBrains)) {`
`52`	`51`	`returnnewChannel`
`53`	`52`	`}`
`54`	`53`

Comments

(0)