Commit2447970

committed

Add unit test to confirm tracking

1 parentc9a226f commit2447970Copy full SHA for 2447970

File tree

+24

-2

lines changed

+24

-2

lines changed

Lines changed: 22 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -191,6 +191,28 @@ func TestAgent_Stats_Magic(t *testing.T) {`
`191`	`191`	`err=session.Wait()`
`192`	`192`	`require.NoError(t,err)`
`193`	`193`	`})`
	`194`	`+`
	`195`	`+// This test name being "Jetbrains" is required to be a certain string.`
	`196`	`+// It must match the regex check in the agent for Jetbrains.`
	`197`	`+t.Run("Jetbrains",func(t*testing.T) {`
	`198`	`+t.Parallel()`
	`199`	`+ctx:=testutil.Context(t,testutil.WaitLong)`
	`200`	`+`
	`201`	`+rl,err:=net.Listen("tcp","127.0.0.1:0")`
	`202`	`+require.NoError(t,err)`
	`203`	`+deferrl.Close()`
	`204`	`+tcpAddr,valid:=rl.Addr().(*net.TCPAddr)`
	`205`	`+require.True(t,valid)`
	`206`	`+remotePort:=tcpAddr.Port`
	`207`	`+goechoOnce(t,rl)`
	`208`	`+`
	`209`	`+sshClient:=setupAgentSSHClient(ctx,t)`
	`210`	`+`
	`211`	`+conn,err:=sshClient.Dial("tcp",fmt.Sprintf("127.0.0.1:%d",remotePort))`
	`212`	`+require.NoError(t,err)`
	`213`	`+deferconn.Close()`
	`214`	`+requireEcho(t,conn)`
	`215`	`+})`
`194`	`216`	`}`
`195`	`217`
`196`	`218`	`funcTestAgent_SessionExec(t*testing.T) {`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -295,8 +295,8 @@ func (s *Server) sessionStart(logger slog.Logger, session ssh.Session, extraEnv`
`295`	`295`	`s.connCountVSCode.Add(1)`
`296`	`296`	`defers.connCountVSCode.Add(-1)`
`297`	`297`	`caseMagicSessionTypeJetBrains:`
`298`		`-s.connCountJetBrains.Add(1)`
`299`		`-defers.connCountJetBrains.Add(-1)`
	`298`	`+// Do nothing here because jetbrains launches hundreds of ssh sessions.`
	`299`	`+// We instead track jetbrains in the single persistent tcp forwarding channel.`
`300`	`300`	`case"":`
`301`	`301`	`s.connCountSSHSession.Add(1)`
`302`	`302`	`defers.connCountSSHSession.Add(-1)`

Comments

(0)