Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit2377d76

Browse files
test: ensure the return value of MockAuditor.Contains is checked (#18319)
It unfortunately doesn't seem possible, even with a custom ruleguard rule, to mark a function as requiring it's return value be used, it looks like you have to go all in on a linter that rejects *any* unused return values.
1 parentdd27a28 commit2377d76

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

‎coderd/agentapi/audit_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ func TestAuditReport(t *testing.T) {
135135
},
136136
})
137137

138-
mAudit.Contains(t, database.AuditLog{
138+
require.True(t,mAudit.Contains(t, database.AuditLog{
139139
Time:dbtime.Time(tt.time).In(time.UTC),
140140
Action:agentProtoConnectionActionToAudit(t,*tt.action),
141141
OrganizationID:workspace.OrganizationID,
@@ -146,7 +146,7 @@ func TestAuditReport(t *testing.T) {
146146
ResourceTarget:agent.Name,
147147
Ip: pqtype.Inet{Valid:true,IPNet: net.IPNet{IP:net.ParseIP(tt.ip),Mask:net.CIDRMask(32,32)}},
148148
StatusCode:tt.status,
149-
})
149+
}))
150150

151151
// Check some additional fields.
152152
varmmap[string]any

‎coderd/userauth_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1577,10 +1577,10 @@ func TestUserOIDC(t *testing.T) {
15771577
})
15781578
require.Equal(t,http.StatusOK,resp.StatusCode)
15791579

1580-
auditor.Contains(t, database.AuditLog{
1580+
require.True(t,auditor.Contains(t, database.AuditLog{
15811581
ResourceType:database.ResourceTypeUser,
15821582
AdditionalFields:json.RawMessage(`{"automatic_actor":"coder","automatic_subsystem":"dormancy"}`),
1583-
})
1583+
}))
15841584
me,err:=client.User(ctx,"me")
15851585
require.NoError(t,err)
15861586

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp