Commit22e49c4

authored

feat(cli): add error message for bad login URL (#4042)

1 parent62d97b1 commit22e49c4Copy full SHA for 22e49c4

File tree

+11

-1

lines changed

+11

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ func login() *cobra.Command {`
`83`	`83`
`84`	`84`	`hasInitialUser,err:=client.HasFirstUser(cmd.Context())`
`85`	`85`	`iferr!=nil {`
`86`		`-returnxerrors.Errorf("has initial user: %w",err)`
	`86`	`+returnxerrors.Errorf("Failed to check server %q for first user, is the URL correct and is coder accessible from your browser? Error -has initial user: %w",serverURL.String(),err)`
`87`	`87`	`}`
`88`	`88`	`if!hasInitialUser {`
`89`	`89`	`_,_=fmt.Fprintf(cmd.OutOrStdout(),caret+"Your Coder deployment hasn't been set up!\n")`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ package cli_test`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"context"`
	`5`	`+"fmt"`
`5`	`6`	`"testing"`
`6`	`7`
`7`	`8`	`"github.com/stretchr/testify/assert"`
`@@ -23,6 +24,15 @@ func TestLogin(t *testing.T) {`
`23`	`24`	`require.Error(t,err)`
`24`	`25`	`})`
`25`	`26`
	`27`	`+t.Run("InitialUserBadLoginURL",func(t*testing.T) {`
	`28`	`+t.Parallel()`
	`29`	`+badLoginURL:="https://fcca2077f06e68aaf9"`
	`30`	`+root,_:=clitest.New(t,"login",badLoginURL)`
	`31`	`+err:=root.Execute()`
	`32`	`+errMsg:=fmt.Sprintf("Failed to check server %q for first user, is the URL correct and is coder accessible from your browser?",badLoginURL)`
	`33`	`+require.ErrorContains(t,err,errMsg)`
	`34`	`+})`
	`35`	`+`
`26`	`36`	`t.Run("InitialUserTTY",func(t*testing.T) {`
`27`	`37`	`t.Parallel()`
`28`	`38`	`client:=coderdtest.New(t,nil)`

Comments

(0)