Commit1ebc2df

committed

fix: Allow setting STUN to an empty string (#1502)

This allows users to entirely disable STUN.

1 parenta1a3d24 commit1ebc2dfCopy full SHA for 1ebc2df

File tree

+15

-1

lines changed

+15

-1

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,11 @@ func StringVarP(flagset pflag.FlagSet, p string, name string, shorthand string`
`40`	`40`	`funcStringArrayVarP(flagsetpflag.FlagSet,ptr[]string,namestring,shorthandstring,envstring,def []string,usagestring) {`
`41`	`41`	`val,ok:=os.LookupEnv(env)`
`42`	`42`	`ifok {`
`43`		`-def=strings.Split(val,",")`
	`43`	`+ifval=="" {`
	`44`	`+def= []string{}`
	`45`	`+}else {`
	`46`	`+def=strings.Split(val,",")`
	`47`	`+}`
`44`	`48`	`}`
`45`	`49`	`flagset.StringArrayVarP(ptr,name,shorthand,def,usage)`
`46`	`50`	`}`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -96,6 +96,16 @@ func TestCliflag(t *testing.T) {`
`96`	`96`	`require.Equal(t, []string{"wow","test"},got)`
`97`	`97`	`})`
`98`	`98`
	`99`	`+t.Run("StringArrayEnvVarEmpty",func(t*testing.T) {`
	`100`	`+varptr []string`
	`101`	`+flagset,name,shorthand,env,usage:=randomFlag()`
	`102`	`+t.Setenv(env,"")`
	`103`	`+cliflag.StringArrayVarP(flagset,&ptr,name,shorthand,env,nil,usage)`
	`104`	`+got,err:=flagset.GetStringArray(name)`
	`105`	`+require.NoError(t,err)`
	`106`	`+require.Equal(t, []string{},got)`
	`107`	`+})`
	`108`	`+`
`99`	`109`	`t.Run("IntDefault",func(t*testing.T) {`
`100`	`110`	`varptruint8`
`101`	`111`	`flagset,name,shorthand,env,usage:=randomFlag()`

Comments

(0)