NotificationsYou must be signed in to change notification settings
Fork1.1k
Star11.6k

Commit1e8ac6c

authored

fix: don't show promote button for members (cherry-pick#17511) (#17513)

Co-authored-by: Bruno Quaresma <bruno@coder.com>Co-authored-by: M Atif Ali <atif@coder.com>fix: don't show promote button for members (#17511)Fix#15850

1 parentb8ffc29 commit1e8ac6cCopy full SHA for 1e8ac6c

File tree

1 file changed

-3

lines changed

site/src/pages/TemplatePage/TemplateVersionsPage
- VersionRow.tsx

1 file changed

-3

lines changed

`‎site/src/pages/TemplatePage/TemplateVersionsPage/VersionRow.tsx‎`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,6 @@ export const VersionRow: FC<VersionRowProps> = ({`
`33`	`33`	`});`
`34`	`34`
`35`	`35`	`constjobStatus=version.job.status;`
`36`		`-constshowActions=onPromoteClick\|\|onArchiveClick;`
`37`	`36`
`38`	`37`	`return(`
`39`	`38`	`<TimelineEntry`
`@@ -106,7 +105,7 @@ export const VersionRow: FC<VersionRowProps> = ({`
`106`	`105`	`</Pill>`
`107`	`106`	`)}`
`108`	`107`
`109`		`-{showActions&&jobStatus==="failed"?(`
	`108`	`+{jobStatus==="failed"&&onArchiveClick&&(`
`110`	`109`	`<Button`
`111`	`110`	`css={styles.promoteButton}`
`112`	`111`	`disabled={isActive\|\|version.archived}`
`@@ -118,7 +117,9 @@ export const VersionRow: FC<VersionRowProps> = ({`
`118`	`117`	`>`
`119`	`118`	`Archive…`
`120`	`119`	`</Button>`
`121`		`-) :(`
	`120`	`+)}`
	`121`	`+`
	`122`	`+{jobStatus==="succeeded"&&onPromoteClick&&(`
`122`	`123`	`<Button`
`123`	`124`	`css={styles.promoteButton}`
`124`	`125`	`disabled={isActive\|\|jobStatus!=="succeeded"}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1e8ac6c

File tree

1 file changed

1 file changed

`‎site/src/pages/TemplatePage/TemplateVersionsPage/VersionRow.tsx‎`

0 commit comments