Commit1e3121b

committed

fix: do not use user_link for deleted accounts

1 parent4126f9e commit1e3121bCopy full SHA for 1e3121b

File tree

+17

-3

lines changed

+17

-3

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3787,6 +3787,10 @@ func (q *FakeQuerier) GetUserLinkByLinkedID(_ context.Context, id string) (datab`
`3787`	`3787`	`deferq.mutex.RUnlock()`
`3788`	`3788`
`3789`	`3789`	`for_,link:=rangeq.userLinks {`
	`3790`	`+user,err:=q.getUserByIDNoLock(link.UserID)`
	`3791`	`+iferr==nil&&user.Deleted {`
	`3792`	`+continue`
	`3793`	`+}`
`3790`	`3794`	`iflink.LinkedID==id {`
`3791`	`3795`	`returnlink,nil`
`3792`	`3796`	`}`

Lines changed: 5 additions & 1 deletion

Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,14 @@`
`1`	`1`	`-- name: GetUserLinkByLinkedID :one`
`2`	`2`	`SELECT`
`3`		`-*`
	`3`	`+user_links.*`
`4`	`4`	`FROM`
`5`	`5`	`user_links`
	`6`	`+INNER JOIN`
	`7`	`+usersONuser_links.user_id=users.id`
`6`	`8`	`WHERE`
`7`		`-linked_id= $1;`
	`9`	`+linked_id= $1`
	`10`	`+AND`
	`11`	`+deleted= false;`
`8`	`12`
`9`	`13`	`-- name: GetUserLinkByUserIDLoginType :one`
`10`	`14`	`SELECT`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -661,6 +661,8 @@ func TestUserOAuth2Github(t *testing.T) {`
`661`	`661`
`662`	`662`	`client,_=fake.Login(t,client, jwt.MapClaims{})`
`663`	`663`	`deleted,err:=client.User(ctx,"me")`
	`664`	`+require.NoError(t,err)`
	`665`	`+`
`664`	`666`	`err=owner.DeleteUser(ctx,deleted.ID)`
`665`	`667`	`require.NoError(t,err)`
`666`	`668`

Comments

(0)