Commit1e0051a

and

authored

feat(testutil): add GetRandomNameHyphenated (#17342)

This started coming up more often for me, so time for a test helper!---------Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

1 parent46d4b28 commit1e0051aCopy full SHA for 1e0051a

File tree

+11

-2

lines changed

+11

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -534,7 +534,7 @@ func TestTemplatePush(t *testing.T) {`
`534`	`534`	`"test_name":tt.name,`
`535`	`535`	`}))`
`536`	`536`
`537`		`-templateName:=strings.ReplaceAll(testutil.GetRandomName(t),"_","-")`
	`537`	`+templateName:=testutil.GetRandomNameHyphenated(t)`
`538`	`538`
`539`	`539`	`inv,root:=clitest.New(t,"templates","push",templateName,"-d",tempDir,"--yes")`
`540`	`540`	`clitest.SetupConfig(t,templateAdmin,root)`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -617,7 +617,7 @@ func TestPostTemplateVersionsByOrganization(t *testing.T) {`
`617`	`617`	`require.NoError(t,err)`
`618`	`618`
`619`	`619`	`// Create a template version from the archive`
`620`		`-tvName:=strings.ReplaceAll(testutil.GetRandomName(t),"_","-")`
	`620`	`+tvName:=testutil.GetRandomNameHyphenated(t)`
`621`	`621`	`tv,err:=templateAdmin.CreateTemplateVersion(ctx,owner.OrganizationID, codersdk.CreateTemplateVersionRequest{`
`622`	`622`	`Name:tvName,`
`623`	`623`	`StorageMethod:codersdk.ProvisionerStorageMethodFile,`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ package testutil`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"strconv"`
	`5`	`+"strings"`
`5`	`6`	`"sync/atomic"`
`6`	`7`	`"testing"`
`7`	`8`
`@@ -25,6 +26,14 @@ func GetRandomName(t testing.TB) string {`
`25`	`26`	`returnincSuffix(name,n.Add(1),maxNameLen)`
`26`	`27`	`}`
`27`	`28`
	`29`	`+// GetRandomNameHyphenated is as GetRandomName but uses a hyphen "-" instead of`
	`30`	`+// an underscore.`
	`31`	`+funcGetRandomNameHyphenated(t testing.TB)string {`
	`32`	`+t.Helper()`
	`33`	`+name:=namesgenerator.GetRandomName(0)`
	`34`	`+returnstrings.ReplaceAll(name,"_","-")`
	`35`	`+}`
	`36`	`+`
`28`	`37`	`funcincSuffix(sstring,numint64,maxLenint)string {`
`29`	`38`	`suffix:=strconv.FormatInt(num,10)`
`30`	`39`	`iflen(s)+len(suffix)<=maxLen {`

Comments

(0)