Commit1cc10f2

authored

fix: only sum connection latencies when they are set (#6524)

This was producing a median that didn't make sense.

1 parent1199a93 commit1cc10f2Copy full SHA for 1cc10f2

File tree

-2

lines changed

-2

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -340,6 +340,9 @@ func (q *fakeQuerier) GetDeploymentWorkspaceAgentStats(_ context.Context, create`
`340`	`340`
`341`	`341`	`latencies:=make([]float64,0)`
`342`	`342`	`for_,agentStat:=rangeagentStatsCreatedAfter {`
	`343`	`+ifagentStat.ConnectionMedianLatencyMS<=0 {`
	`344`	`+continue`
	`345`	`+}`
`343`	`346`	`stat.WorkspaceRxBytes+=agentStat.RxBytes`
`344`	`347`	`stat.WorkspaceTxBytes+=agentStat.TxBytes`
`345`	`348`	`latencies=append(latencies,agentStat.ConnectionMedianLatencyMS)`

Lines changed: 2 additions & 1 deletion

Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,8 @@ WITH agent_stats AS (`
`60`	`60`	`coalesce((PERCENTILE_CONT(0.5) WITHIN GROUP (ORDER BY connection_median_latency_ms)),-1)::FLOATAS workspace_connection_latency_50,`
`61`	`61`	`coalesce((PERCENTILE_CONT(0.95) WITHIN GROUP (ORDER BY connection_median_latency_ms)),-1)::FLOATAS workspace_connection_latency_95`
`62`	`62`	`FROM workspace_agent_stats`
`63`		`-WHEREworkspace_agent_stats.created_at> $1`
	`63`	`+-- The greater than 0 is to support legacy agents that don't report connection_median_latency_ms.`
	`64`	`+WHEREworkspace_agent_stats.created_at> $1AND connection_median_latency_ms>0`
`64`	`65`	`), latest_agent_statsAS (`
`65`	`66`	`SELECT`
`66`	`67`	`coalesce(SUM(session_count_vscode),0)::bigintAS session_count_vscode,`

Comments

(0)