Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit1cb776a

Browse files
committed
Stub out RBAC test
Signed-off-by: Danny Kopping <danny@coder.com>
1 parentd8c2d00 commit1cb776a

File tree

2 files changed

+45
-20
lines changed

2 files changed

+45
-20
lines changed

‎coderd/database/dbauthz/dbauthz_test.go

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2435,6 +2435,36 @@ func (s *MethodTestSuite) TestSystemFunctions() {
24352435
AgentID:uuid.New(),
24362436
}).Asserts(tpl,policy.ActionCreate)
24372437
}))
2438+
s.Run("AcquireNotificationMessages",s.Subtest(func(db database.Store,check*expects) {
2439+
// TODO: update this test once we have a specific role for notifications
2440+
check.Args(database.AcquireNotificationMessagesParams{}).Asserts(rbac.ResourceSystem,policy.ActionUpdate)
2441+
}))
2442+
s.Run("BulkMarkNotificationMessagesFailed",s.Subtest(func(db database.Store,check*expects) {
2443+
// TODO: update this test once we have a specific role for notifications
2444+
check.Args(database.BulkMarkNotificationMessagesFailedParams{}).Asserts(rbac.ResourceSystem,policy.ActionUpdate)
2445+
}))
2446+
s.Run("BulkMarkNotificationMessagesSent",s.Subtest(func(db database.Store,check*expects) {
2447+
// TODO: update this test once we have a specific role for notifications
2448+
check.Args(database.BulkMarkNotificationMessagesSentParams{}).Asserts(rbac.ResourceSystem,policy.ActionUpdate)
2449+
}))
2450+
s.Run("DeleteOldNotificationMessages",s.Subtest(func(db database.Store,check*expects) {
2451+
// TODO: update this test once we have a specific role for notifications
2452+
check.Args().Asserts(rbac.ResourceSystem,policy.ActionDelete)
2453+
}))
2454+
s.Run("EnqueueNotificationMessage",s.Subtest(func(db database.Store,check*expects) {
2455+
// TODO: update this test once we have a specific role for notifications
2456+
check.Args(database.EnqueueNotificationMessageParams{
2457+
Method:database.NotificationMethodWebhook,
2458+
}).Asserts(rbac.ResourceSystem,policy.ActionCreate)
2459+
}))
2460+
s.Run("FetchNewMessageMetadata",s.Subtest(func(db database.Store,check*expects) {
2461+
// TODO: update this test once we have a specific role for notifications
2462+
check.Args(database.FetchNewMessageMetadataParams{}).Asserts(rbac.ResourceSystem,policy.ActionRead)
2463+
}))
2464+
s.Run("InsertNotificationTemplate",s.Subtest(func(db database.Store,check*expects) {
2465+
// TODO: update this test once we have a specific role for notifications
2466+
check.Args(database.InsertNotificationTemplateParams{}).Asserts(rbac.ResourceSystem,policy.ActionCreate)
2467+
}))
24382468
}
24392469

24402470
func (s*MethodTestSuite)TestOAuth2ProviderApps() {

‎coderd/database/dbmem/dbmem.go

Lines changed: 15 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -905,13 +905,13 @@ func (*FakeQuerier) AcquireLock(_ context.Context, _ int64) error {
905905
returnxerrors.New("AcquireLock must only be called within a transaction")
906906
}
907907

908-
func (q*FakeQuerier)AcquireNotificationMessages(ctx context.Context,arg database.AcquireNotificationMessagesParams) ([]database.AcquireNotificationMessagesRow,error) {
908+
func (*FakeQuerier)AcquireNotificationMessages(_ context.Context,arg database.AcquireNotificationMessagesParams) ([]database.AcquireNotificationMessagesRow,error) {
909909
err:=validateDatabaseType(arg)
910910
iferr!=nil {
911911
returnnil,err
912912
}
913-
914-
panic("not implemented")
913+
// nolint:nilnil // Irrelevant.
914+
returnnil,nil
915915
}
916916

917917
func (q*FakeQuerier)AcquireProvisionerJob(_ context.Context,arg database.AcquireProvisionerJobParams) (database.ProvisionerJob,error) {
@@ -1176,22 +1176,20 @@ func (q *FakeQuerier) BatchUpdateWorkspaceLastUsedAt(_ context.Context, arg data
11761176
returnnil
11771177
}
11781178

1179-
func (q*FakeQuerier)BulkMarkNotificationMessagesFailed(ctx context.Context,arg database.BulkMarkNotificationMessagesFailedParams) (int64,error) {
1179+
func (*FakeQuerier)BulkMarkNotificationMessagesFailed(_ context.Context,arg database.BulkMarkNotificationMessagesFailedParams) (int64,error) {
11801180
err:=validateDatabaseType(arg)
11811181
iferr!=nil {
11821182
return0,err
11831183
}
1184-
1185-
panic("not implemented")
1184+
return-1,nil
11861185
}
11871186

1188-
func (q*FakeQuerier)BulkMarkNotificationMessagesSent(ctx context.Context,arg database.BulkMarkNotificationMessagesSentParams) (int64,error) {
1187+
func (*FakeQuerier)BulkMarkNotificationMessagesSent(_ context.Context,arg database.BulkMarkNotificationMessagesSentParams) (int64,error) {
11891188
err:=validateDatabaseType(arg)
11901189
iferr!=nil {
11911190
return0,err
11921191
}
1193-
1194-
panic("not implemented")
1192+
return-1,nil
11951193
}
11961194

11971195
func (*FakeQuerier)CleanTailnetCoordinators(_ context.Context)error {
@@ -1529,8 +1527,8 @@ func (q *FakeQuerier) DeleteOAuth2ProviderAppTokensByAppAndUserID(_ context.Cont
15291527
returnnil
15301528
}
15311529

1532-
func (q*FakeQuerier)DeleteOldNotificationMessages(ctx context.Context)error {
1533-
panic("not implemented")
1530+
func (*FakeQuerier)DeleteOldNotificationMessages(_ context.Context)error {
1531+
returnnil
15341532
}
15351533

15361534
func (q*FakeQuerier)DeleteOldProvisionerDaemons(_ context.Context)error {
@@ -1748,13 +1746,12 @@ func (q *FakeQuerier) DeleteWorkspaceAgentPortSharesByTemplate(_ context.Context
17481746
returnnil
17491747
}
17501748

1751-
func (q*FakeQuerier)EnqueueNotificationMessage(ctx context.Context,arg database.EnqueueNotificationMessageParams) (database.NotificationMessage,error) {
1749+
func (*FakeQuerier)EnqueueNotificationMessage(_ context.Context,arg database.EnqueueNotificationMessageParams) (database.NotificationMessage,error) {
17521750
err:=validateDatabaseType(arg)
17531751
iferr!=nil {
17541752
return database.NotificationMessage{},err
17551753
}
1756-
1757-
panic("not implemented")
1754+
return database.NotificationMessage{},nil
17581755
}
17591756

17601757
func (q*FakeQuerier)FavoriteWorkspace(_ context.Context,arg uuid.UUID)error {
@@ -1776,13 +1773,12 @@ func (q *FakeQuerier) FavoriteWorkspace(_ context.Context, arg uuid.UUID) error
17761773
returnnil
17771774
}
17781775

1779-
func (q*FakeQuerier)FetchNewMessageMetadata(ctx context.Context,arg database.FetchNewMessageMetadataParams) (database.FetchNewMessageMetadataRow,error) {
1776+
func (*FakeQuerier)FetchNewMessageMetadata(_ context.Context,arg database.FetchNewMessageMetadataParams) (database.FetchNewMessageMetadataRow,error) {
17801777
err:=validateDatabaseType(arg)
17811778
iferr!=nil {
17821779
return database.FetchNewMessageMetadataRow{},err
17831780
}
1784-
1785-
panic("not implemented")
1781+
return database.FetchNewMessageMetadataRow{},nil
17861782
}
17871783

17881784
func (q*FakeQuerier)GetAPIKeyByID(_ context.Context,idstring) (database.APIKey,error) {
@@ -6112,13 +6108,12 @@ func (q *FakeQuerier) InsertMissingGroups(_ context.Context, arg database.Insert
61126108
returnnewGroups,nil
61136109
}
61146110

6115-
func (q*FakeQuerier)InsertNotificationTemplate(ctx context.Context,arg database.InsertNotificationTemplateParams) (database.NotificationTemplate,error) {
6111+
func (*FakeQuerier)InsertNotificationTemplate(_ context.Context,arg database.InsertNotificationTemplateParams) (database.NotificationTemplate,error) {
61166112
err:=validateDatabaseType(arg)
61176113
iferr!=nil {
61186114
return database.NotificationTemplate{},err
61196115
}
6120-
6121-
panic("not implemented")
6116+
return database.NotificationTemplate{},nil
61226117
}
61236118

61246119
func (q*FakeQuerier)InsertOAuth2ProviderApp(_ context.Context,arg database.InsertOAuth2ProviderAppParams) (database.OAuth2ProviderApp,error) {

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp