Commit1ba02f4

authored

chore(dogfood): increase container graceful stop time (#17528)

Fixes workspace stop when you've run `devcontainer up` in coder/coder.The previous attempt in#17110 gave insufficient time.

1 parent0ef7d0b commit1ba02f4Copy full SHA for 1ba02f4

File tree

-3

lines changed

-3

lines changed

Lines changed: 9 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -425,10 +425,16 @@ resource "docker_container" "workspace" {`
`425`	`425`	`# CPU limits are unnecessary since Docker will load balance automatically`
`426`	`426`	`memory=data.coder_workspace_owner.me.name=="code-asher"?65536:32768`
`427`	`427`	`runtime="sysbox-runc"`
`428`		`-# Ensure the workspace is given time to execute shutdown scripts.`
`429`		`-destroy_grace_seconds=60`
`430`		`-stop_timeout=60`
	`428`	`+`
	`429`	`+# Ensure the workspace is given time to:`
	`430`	`+# - Execute shutdown scripts`
	`431`	`+# - Stop the in workspace Docker daemon`
	`432`	`+# - Stop the container, especially when using devcontainers,`
	`433`	`+# deleting the overlay filesystem can take a while.`
	`434`	`+destroy_grace_seconds=300`
	`435`	`+stop_timeout=300`
`431`	`436`	`stop_signal="SIGINT"`
	`437`	`+`
`432`	`438`	`env=[`
`433`	`439`	`"CODER_AGENT_TOKEN=${coder_agent.dev.token}",`
`434`	`440`	`"USE_CAP_NET_ADMIN=true",`

Comments

(0)