Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit1a39e8b

Browse files
committed
chore(coderd/database/dbpurge): move check for agent logs inside mustCreateAgentWithLogs
1 parent5508304 commit1a39e8b

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

‎coderd/database/dbpurge/dbpurge_test.go‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -179,31 +179,24 @@ func TestDeleteOldWorkspaceAgentLogs(t *testing.T) {
179179
defercancel()
180180

181181
// given
182-
agent:=mustCreateAgentWithLogs(ctx,t,db,user,org,tmpl,tv,now.Add(-8*24*time.Hour),t.Name())
183-
184-
// Make sure that agent logs have been collected.
185-
agentLogs,err:=db.GetWorkspaceAgentLogsAfter(ctx, database.GetWorkspaceAgentLogsAfterParams{
186-
AgentID:agent,
187-
})
188-
require.NoError(t,err)
189-
require.NotZero(t,agentLogs,"agent logs must be present")
182+
agent1:=mustCreateAgentWithLogs(ctx,t,db,user,org,tmpl,tv,now.Add(-8*24*time.Hour),t.Name()+"-1")
190183

191184
// when
192185
closer:=dbpurge.New(ctx,logger,db)
193186
defercloser.Close()
194187

195188
// then
196189
assert.Eventually(t,func()bool {
197-
agentLogs,err=db.GetWorkspaceAgentLogsAfter(ctx, database.GetWorkspaceAgentLogsAfterParams{
198-
AgentID:agent,
190+
agentLogs,err:=db.GetWorkspaceAgentLogsAfter(ctx, database.GetWorkspaceAgentLogsAfterParams{
191+
AgentID:agent1,
199192
})
200193
iferr!=nil {
201194
returnfalse
202195
}
196+
assert.NoError(t,err)
197+
assert.NotContains(t,agentLogs,t.Name())
203198
return!containsAgentLog(agentLogs,t.Name())
204199
},testutil.WaitShort,testutil.IntervalFast)
205-
require.NoError(t,err)
206-
require.NotContains(t,agentLogs,t.Name())
207200
})
208201

209202
//nolint:paralleltest // It uses LockIDDBPurge.
@@ -246,6 +239,12 @@ func mustCreateAgentWithLogs(ctx context.Context, t *testing.T, db database.Stor
246239
Level: []database.LogLevel{database.LogLevelDebug},
247240
})
248241
require.NoError(t,err)
242+
// Make sure that agent logs have been collected.
243+
agentLogs,err:=db.GetWorkspaceAgentLogsAfter(ctx, database.GetWorkspaceAgentLogsAfterParams{
244+
AgentID:agent.ID,
245+
})
246+
require.NoError(t,err)
247+
require.NotZero(t,agentLogs,"agent logs must be present")
249248
returnagent.ID
250249
}
251250

@@ -268,6 +267,7 @@ func mustCreateAgent(t *testing.T, db database.Store, user database.User, org da
268267
JobID:job.ID,
269268
Transition:database.WorkspaceTransitionStart,
270269
})
270+
271271
returndbgen.WorkspaceAgent(t,db, database.WorkspaceAgent{
272272
ResourceID:resource.ID,
273273
})

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp