Commit19e896a

committed

address PR comments

1 parent2159ac6 commit19e896aCopy full SHA for 19e896a

File tree

-7

lines changed

-7

lines changed

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -444,8 +444,7 @@ func New(options Options) API {`
`444`	`444`	`CurrentVersion:buildinfo.Version(),`
`445`	`445`	`CurrentAPIMajorVersion:provisionersdk.CurrentMajor,`
`446`	`446`	`Store:options.Database,`
`447`		`-TimeNowFn:dbtime.Now,`
`448`		`-StaleInterval:provisionerdserver.DefaultHeartbeatInterval*3,`
	`447`	`+// TimeNow and StaleInterval set to defaults, see healthcheck/provisioner.go`
`449`	`448`	`},`
`450`	`449`	`})`
`451`	`450`	`}`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ type ProvisionerDaemonsReportDeps struct {`
`36`	`36`	`StoreProvisionerDaemonsStore`
`37`	`37`
`38`	`38`	`// Optional`
`39`		`-TimeNowFnfunc() time.Time// Defaults to dbtime.Now`
	`39`	`+TimeNowfunc() time.Time// Defaults to dbtime.Now`
`40`	`40`	`StaleInterval time.Duration// Defaults to 3 heartbeats`
`41`	`41`
`42`	`42`	`Dismissedbool`
`@@ -52,10 +52,10 @@ func (r ProvisionerDaemonsReport) Run(ctx context.Context, opts ProvisionerDae`
`52`	`52`	`r.Warnings=make([]health.Message,0)`
`53`	`53`	`r.Dismissed=opts.Dismissed`
`54`	`54`
`55`		`-ifopts.TimeNowFn==nil {`
`56`		`-opts.TimeNowFn=dbtime.Now`
	`55`	`+ifopts.TimeNow==nil {`
	`56`	`+opts.TimeNow=dbtime.Now`
`57`	`57`	`}`
`58`		`-now:=opts.TimeNowFn()`
	`58`	`+now:=opts.TimeNow()`
`59`	`59`
`60`	`60`	`ifopts.StaleInterval==0 {`
`61`	`61`	`opts.StaleInterval=provisionerdserver.DefaultHeartbeatInterval*3`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ func TestProvisionerDaemonReport(t *testing.T) {`
`136`	`136`	`deps.CurrentAPIMajorVersion=provisionersdk.CurrentMajor`
`137`	`137`	`}`
`138`	`138`	`now:=dbtime.Now()`
`139`		`-deps.TimeNowFn=func() time.Time {`
	`139`	`+deps.TimeNow=func() time.Time {`
`140`	`140`	`returnnow`
`141`	`141`	`}`
`142`	`142`

Comments

(0)