Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit1961252

Browse files
authored
chore(coderd/provisionerdserver): address flake in TestServer_ExpirePrebuildsSessionToken (#20648)
Addresses a flake seen locally by@mafredri:```panic: interface conversion: proto.isAcquiredJob_Type is nil, not *proto.AcquiredJob_WorkspaceBuild_ [recovered] panic: interface conversion: proto.isAcquiredJob_Type is nil, not *proto.AcquiredJob_WorkspaceBuild_goroutine 77 [running]:testing.tRunner.func1.2({0x35ba440, 0xc000f15620}) /usr/local/go/src/testing/testing.go:1734 +0x21ctesting.tRunner.func1() /usr/local/go/src/testing/testing.go:1737 +0x35epanic({0x35ba440?, 0xc000f15620?}) /usr/local/go/src/runtime/panic.go:792 +0x132github.com/coder/coder/v2/coderd/provisionerdserver_test.TestServer_ExpirePrebuildsSessionToken(0xc00010d500) /home/coder/coder/coderd/provisionerdserver/provisionerdserver_test.go:4128 +0xc4btesting.tRunner(0xc00010d500, 0x4bd8450) /usr/local/go/src/testing/testing.go:1792 +0xf4created by testing.(*T).Run in goroutine 1 /usr/local/go/src/testing/testing.go:1851 +0x413FAIL github.com/coder/coder/v2/coderd/provisionerdserver 20.830sFAIL```It's unclear why this would happen in the first place.
1 parent11f2411 commit1961252

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

‎coderd/provisionerdserver/provisionerdserver_test.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4091,6 +4091,7 @@ func TestServer_ExpirePrebuildsSessionToken(t *testing.T) {
40914091
job,err:=fs.waitForJob()
40924092
require.NoError(t,err)
40934093
require.NotNil(t,job)
4094+
require.NotNil(t,job.Type,"acquired job type was nil?!")
40944095
workspaceBuildJob:=job.Type.(*proto.AcquiredJob_WorkspaceBuild_).WorkspaceBuild
40954096
require.NotNil(t,workspaceBuildJob.Metadata)
40964097

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp