Commit19530c6

authored

fix: updateDeleteWorkspaceOptions to pick properties correctly (#13423)

* fix: update typo* fix: update typo in call site* fix: update type for deleteWorkspace mock* fix: update one more type mismatch

1 parent4758952 commit19530c6Copy full SHA for 19530c6

File tree

-5

lines changed

-5

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,7 @@ type RestartWorkspaceParameters = Readonly<{`
`314`	`314`
`315`	`315`	`exporttypeDeleteWorkspaceOptions=Pick<`
`316`	`316`	`TypesGen.CreateWorkspaceBuildRequest,`
`317`		`-"log_level"&"orphan"`
	`317`	`+"log_level"\|"orphan"`
`318`	`318`	`>;`
`319`	`319`
`320`	`320`	`exporttypeDeploymentConfig=Readonly<{`

Lines changed: 7 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,9 @@ describe("WorkspacePage", () => {`
`161`	`161`	`});`
`162`	`162`	`awaituser.click(confirmButton);`
`163`	`163`	`// arguments are workspace.name, log level (undefined), and orphan`
`164`		`-expect(deleteWorkspaceMock).toBeCalledWith(MockFailedWorkspace.id,{`
	`164`	`+expect(deleteWorkspaceMock).toBeCalledWith<`
	`165`	`+[string,apiModule.DeleteWorkspaceOptions]`
	`166`	`+>(MockFailedWorkspace.id,{`
`165`	`167`	`log_level:undefined,`
`166`	`168`	`orphan:true,`
`167`	`169`	`});`
`@@ -425,8 +427,10 @@ describe("WorkspacePage", () => {`
`425`	`427`
`426`	`428`	`test("Retry with debug logs",async()=>{`
`427`	`429`	`awaittestButton(failedDelete,retryDebugButtonRe,mockDelete);`
`428`		`-expect(mockDelete).toBeCalledWith(failedDelete.id,{`
`429`		`-logLevel:"debug",`
	`430`	`+expect(mockDelete).toBeCalledWith<`
	`431`	`+[string,apiModule.DeleteWorkspaceOptions]`
	`432`	`+>(failedDelete.id,{`
	`433`	`+log_level:"debug",`
`430`	`434`	`});`
`431`	`435`	`});`
`432`	`436`	`});`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ export const WorkspaceReadyPage: FC<WorkspaceReadyPageProps> = ({`
`173`	`173`	`stopWorkspaceMutation.mutate({ logLevel});`
`174`	`174`	`break;`
`175`	`175`	`case"delete":`
`176`		`-deleteWorkspaceMutation.mutate({ logLevel});`
	`176`	`+deleteWorkspaceMutation.mutate({log_level:logLevel});`
`177`	`177`	`break;`
`178`	`178`	`}`
`179`	`179`	`};`

Comments

(0)