Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit18c2386

Browse files
chore(site): fix reset password storybook flake (#15380)
Fixcoder/internal#69
1 parent335e4ab commit18c2386

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

‎site/src/pages/UsersPage/UsersPage.stories.tsx‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,9 @@ const meta: Meta<typeof UsersPage> = {
7272
component:UsersPage,
7373
parameters,
7474
decorators:[withGlobalSnackbar,withAuthProvider,withDashboardProvider],
75+
args:{
76+
defaultNewPassword:"edWbqYiaVpEiEWwI",
77+
},
7578
};
7679

7780
exportdefaultmeta;

‎site/src/pages/UsersPage/UsersPage.tsx‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,13 @@ import { ResetPasswordDialog } from "./ResetPasswordDialog";
3535
import{useStatusFilterMenu}from"./UsersFilter";
3636
import{UsersPageView}from"./UsersPageView";
3737

38-
constUsersPage:FC=()=>{
38+
typeUserPageProps={
39+
// Used by Storybook to prevent generating a new password each time the story
40+
// loads, avoiding Chromatic snapshot differences.
41+
defaultNewPassword?:string;
42+
};
43+
44+
constUsersPage:FC<UserPageProps>=({ defaultNewPassword})=>{
3945
constqueryClient=useQueryClient();
4046
constnavigate=useNavigate();
4147
constlocation=useLocation();
@@ -134,7 +140,7 @@ const UsersPage: FC = () => {
134140
onResetUserPassword={(user)=>{
135141
setConfirmResetPassword({
136142
user,
137-
newPassword:generateRandomString(12),
143+
newPassword:defaultNewPassword??generateRandomString(12),
138144
});
139145
}}
140146
onUpdateUserRoles={async(userId,roles)=>{

‎site/src/pages/UsersPage/UsersPageView.stories.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ const meta: Meta<typeof UsersPageView> = {
3434
isNonInitialPage:false,
3535
users:[MockUser,MockUser2],
3636
roles:MockAssignableSiteRoles,
37-
3837
canEditUsers:true,
3938
filterProps:defaultFilterProps,
4039
authMethods:MockAuthMethodsPasswordOnly,

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp