Commit17fa155

committed

rename start to ready

1 parentfd69221 commit17fa155Copy full SHA for 17fa155

File tree

+10

-7

lines changed

+10

-7

lines changed

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1169,9 +1169,10 @@ func (a agent) handleManifest(manifestOK checkpoint) func(ctx context.Context,`
`1169`	`1169`	`a.metrics.startupScriptSeconds.WithLabelValues(label).Set(dur)`
`1170`	`1170`	`a.scriptRunner.StartCron()`
`1171`	`1171`	`ifa.containerAPI!=nil {`
`1172`		`-// Start the containerAPI service after`
`1173`		`-// devcontainers have been started.`
`1174`		`-a.containerAPI.Start()`
	`1172`	`+// Inform the container API that the agent is ready.`
	`1173`	`+// This allows us to start watching for changes to`
	`1174`	`+// the devcontainer configuration files.`
	`1175`	`+a.containerAPI.Ready()`
`1175`	`1176`	`}`
`1176`	`1177`	`})`
`1177`	`1178`	`iferr!=nil {`

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -151,9 +151,11 @@ func NewAPI(logger slog.Logger, options ...Option) *API {`
`151`	`151`	`returnapi`
`152`	`152`	`}`
`153`	`153`
`154`		`-// Start watching for devcontainer config file changes and prime the`
`155`		`-// cache with the current list of containers.`
`156`		`-func (api*API)Start() {`
	`154`	`+// Ready signals the API that we are ready to begin watching for file`
	`155`	`+// changes. This is used to prime the cache with the current list of`
	`156`	`+// containers and to start watching the devcontainer config files for`
	`157`	`+// changes. It should be called after the agent ready.`
	`158`	`+func (api*API)Ready() {`
`157`	`159`	`// Prime the cache with the current list of containers.`
`158`	`160`	`_,_=api.cl.List(api.ctx)`
`159`	`161`

Lines changed: 1 addition & 1 deletion

Comments

(0)