NotificationsYou must be signed in to change notification settings
Fork1.1k
Star11.6k

Commit14f0844

authored

fix: send all params instead of only touched params (#20740)

resolves#20257Ensure all parameters are sent in the web socket request instead of onlytouched parameters.Using touched parameters is irrelevant for the workspace parameters pagein workspace settings because parameters that appear here have alreadybeen chosen by the user during workspace creation. So all parametersshould be sent in the web socket request whether have been touched inthe form or not.

1 parenta3c851c commit14f0844Copy full SHA for 14f0844

File tree

1 file changed

-23

lines changed

site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage
- WorkspaceParametersPageViewExperimental.tsx

1 file changed

-23

lines changed

`‎site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageViewExperimental.tsx‎`

Lines changed: 5 additions & 23 deletions

Original file line number	Diff line number	Diff line change
`@@ -48,18 +48,6 @@ export const WorkspaceParametersPageViewExperimental: FC<`
`48`	`48`	`onCancel,`
`49`	`49`	`templateVersionId,`
`50`	`50`	`})=>{`
`51`		`-constautofillByName=Object.fromEntries(`
`52`		`-autofillParameters.map((param)=>[param.name,param]),`
`53`		`-);`
`54`		`-constinitialTouched=parameters.reduce(`
`55`		`-(touched,parameter)=>{`
`56`		`-if(autofillByName[parameter.name]!==undefined){`
`57`		`-touched[parameter.name]=true;`
`58`		`-}`
`59`		`-returntouched;`
`60`		`-},`
`61`		`-{}asRecord<string,boolean>,`
`62`		`-);`
`63`	`51`	`constform=useFormik({`
`64`	`52`	`onSubmit,`
`65`	`53`	`initialValues:{`
`@@ -68,7 +56,6 @@ export const WorkspaceParametersPageViewExperimental: FC<`
`68`	`56`	`autofillParameters,`
`69`	`57`	`),`
`70`	`58`	`},`
`71`		`-initialTouched,`
`72`	`59`	`validationSchema:useValidationSchemaForDynamicParameters(parameters),`
`73`	`60`	`enableReinitialize:false,`
`74`	`61`	`validateOnChange:true,`
`@@ -89,28 +76,23 @@ export const WorkspaceParametersPageViewExperimental: FC<`
`89`	`76`	`name:parameter.name,`
`90`	`77`	`value,`
`91`	`78`	`});`
`92`		`-form.setFieldTouched(parameter.name,true);`
`93`	`79`	`sendDynamicParamsRequest(parameter,value);`
`94`	`80`	`};`
`95`	`81`
`96`		`-// Send the changed parameter and all touched parameters to the websocket`
`97`	`82`	`constsendDynamicParamsRequest=(`
`98`	`83`	`parameter:PreviewParameter,`
`99`	`84`	`value:string,`
`100`	`85`	`)=>{`
`101`	`86`	`constformInputs:Record<string,string>={};`
`102`		`-formInputs[parameter.name]=value;`
`103`	`87`	`constparameters=form.values.rich_parameter_values??[];`
`104`		`-`
`105`		`-for(const[fieldName,isTouched]ofObject.entries(form.touched)){`
`106`		`-if(isTouched&&fieldName!==parameter.name){`
`107`		`-constparam=parameters.find((p)=>p.name===fieldName);`
`108`		`-if(param?.value){`
`109`		`-formInputs[fieldName]=param.value;`
`110`		`-}`
	`88`	`+for(constparamofparameters){`
	`89`	`+if(param?.name&&param?.value){`
	`90`	`+formInputs[param.name]=param.value;`
`111`	`91`	`}`
`112`	`92`	`}`
`113`	`93`
	`94`	`+formInputs[parameter.name]=value;`
	`95`	`+`
`114`	`96`	`sendMessage(formInputs);`
`115`	`97`	`};`
`116`	`98`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit14f0844

File tree

1 file changed

1 file changed

`‎site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageViewExperimental.tsx‎`

0 commit comments