Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit1483fd1

Browse files
authored
fix(coderd/database): improve task status in tasks_with_status view (#20683)
This change restructures the `tasks_with_status` view query to:- Improve debuggability by adding a `status_debug` column to betterunderstand the outcome- Reduce clutter from `bool_or`, `bool_and` which are aggregatefunctions that did not actually have serve a purpose (each join is 0-1rows)- Improve agent lifecycle state coverage, `start_timeout` and`start_error` were omitted- These states are easy to trigger even in a perfectly functioningworkspace/task so we now rely on app health to report whether or notthere was an issue- Mark canceling and canceled workspace build jobs as error state- Agent stop states were implicitly `unknown`, now there are explicit (Iinitially considered `error`, could go either way)
1 parent6067aa3 commit1483fd1

File tree

7 files changed

+354
-55
lines changed

7 files changed

+354
-55
lines changed

‎coderd/database/dump.sql‎

Lines changed: 36 additions & 28 deletions
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.
Lines changed: 82 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,82 @@
1+
-- Restore previous view.
2+
DROPVIEW IF EXISTS tasks_with_status;
3+
4+
CREATE VIEW
5+
tasks_with_status
6+
AS
7+
SELECT
8+
tasks.*,
9+
CASE
10+
WHENtasks.workspace_id ISNULLORlatest_build.job_status ISNULL THEN'pending'::task_status
11+
12+
WHENlatest_build.job_status='failed' THEN'error'::task_status
13+
14+
WHENlatest_build.transitionIN ('stop','delete')
15+
ANDlatest_build.job_status='succeeded' THEN'paused'::task_status
16+
17+
WHENlatest_build.transition='start'
18+
ANDlatest_build.job_status='pending' THEN'initializing'::task_status
19+
20+
WHENlatest_build.transition='start'ANDlatest_build.job_statusIN ('running','succeeded') THEN
21+
CASE
22+
WHENagent_status.none THEN'initializing'::task_status
23+
WHENagent_status.connecting THEN'initializing'::task_status
24+
WHENagent_status.connected THEN
25+
CASE
26+
WHENapp_status.any_unhealthy THEN'error'::task_status
27+
WHENapp_status.any_initializing THEN'initializing'::task_status
28+
WHENapp_status.all_healthy_or_disabled THEN'active'::task_status
29+
ELSE'unknown'::task_status
30+
END
31+
ELSE'unknown'::task_status
32+
END
33+
34+
ELSE'unknown'::task_status
35+
ENDAS status,
36+
task_app.*,
37+
task_owner.*
38+
FROM
39+
tasks
40+
CROSS JOIN LATERAL (
41+
SELECT
42+
vu.usernameAS owner_username,
43+
vu.nameAS owner_name,
44+
vu.avatar_urlAS owner_avatar_url
45+
FROM visible_users vu
46+
WHEREvu.id=tasks.owner_id
47+
) task_owner
48+
LEFT JOIN LATERAL (
49+
SELECT workspace_build_number, workspace_agent_id, workspace_app_id
50+
FROM task_workspace_apps task_app
51+
WHERE task_id=tasks.id
52+
ORDER BY workspace_build_numberDESC
53+
LIMIT1
54+
) task_appON TRUE
55+
LEFT JOIN LATERAL (
56+
SELECT
57+
workspace_build.transition,
58+
provisioner_job.job_status,
59+
workspace_build.job_id
60+
FROM workspace_builds workspace_build
61+
JOIN provisioner_jobs provisioner_jobONprovisioner_job.id=workspace_build.job_id
62+
WHEREworkspace_build.workspace_id=tasks.workspace_id
63+
ANDworkspace_build.build_number=task_app.workspace_build_number
64+
) latest_buildON TRUE
65+
CROSS JOIN LATERAL (
66+
SELECT
67+
COUNT(*)=0AS none,
68+
bool_or(workspace_agent.lifecycle_stateIN ('created','starting'))AS connecting,
69+
bool_and(workspace_agent.lifecycle_state='ready')AS connected
70+
FROM workspace_agents workspace_agent
71+
WHEREworkspace_agent.id=task_app.workspace_agent_id
72+
) agent_status
73+
CROSS JOIN LATERAL (
74+
SELECT
75+
bool_or(workspace_app.health='unhealthy')AS any_unhealthy,
76+
bool_or(workspace_app.health='initializing')AS any_initializing,
77+
bool_and(workspace_app.healthIN ('healthy','disabled'))AS all_healthy_or_disabled
78+
FROM workspace_apps workspace_app
79+
WHEREworkspace_app.id=task_app.workspace_app_id
80+
) app_status
81+
WHERE
82+
tasks.deleted_at ISNULL;
Lines changed: 142 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,142 @@
1+
-- Update task status in view.
2+
DROPVIEW IF EXISTS tasks_with_status;
3+
4+
CREATE VIEW
5+
tasks_with_status
6+
AS
7+
SELECT
8+
tasks.*,
9+
-- Combine component statuses with precedence: build -> agent -> app.
10+
CASE
11+
WHENtasks.workspace_id ISNULL THEN'pending'::task_status
12+
WHENbuild_status.status!='active' THENbuild_status.status::task_status
13+
WHENagent_status.status!='active' THENagent_status.status::task_status
14+
ELSEapp_status.status::task_status
15+
ENDAS status,
16+
-- Attach debug information for troubleshooting status.
17+
jsonb_build_object(
18+
'build', jsonb_build_object(
19+
'transition',latest_build_raw.transition,
20+
'job_status',latest_build_raw.job_status,
21+
'computed',build_status.status
22+
),
23+
'agent', jsonb_build_object(
24+
'lifecycle_state',agent_raw.lifecycle_state,
25+
'computed',agent_status.status
26+
),
27+
'app', jsonb_build_object(
28+
'health',app_raw.health,
29+
'computed',app_status.status
30+
)
31+
)AS status_debug,
32+
task_app.*,
33+
agent_raw.lifecycle_stateAS workspace_agent_lifecycle_state,
34+
app_raw.healthAS workspace_app_health,
35+
task_owner.*
36+
FROM
37+
tasks
38+
CROSS JOIN LATERAL (
39+
SELECT
40+
vu.usernameAS owner_username,
41+
vu.nameAS owner_name,
42+
vu.avatar_urlAS owner_avatar_url
43+
FROM
44+
visible_users vu
45+
WHERE
46+
vu.id=tasks.owner_id
47+
) task_owner
48+
LEFT JOIN LATERAL (
49+
SELECT
50+
task_app.workspace_build_number,
51+
task_app.workspace_agent_id,
52+
task_app.workspace_app_id
53+
FROM
54+
task_workspace_apps task_app
55+
WHERE
56+
task_id=tasks.id
57+
ORDER BY
58+
task_app.workspace_build_numberDESC
59+
LIMIT1
60+
) task_appON TRUE
61+
62+
-- Join the raw data for computing task status.
63+
LEFT JOIN LATERAL (
64+
SELECT
65+
workspace_build.transition,
66+
provisioner_job.job_status,
67+
workspace_build.job_id
68+
FROM
69+
workspace_builds workspace_build
70+
JOIN
71+
provisioner_jobs provisioner_job
72+
ONprovisioner_job.id=workspace_build.job_id
73+
WHERE
74+
workspace_build.workspace_id=tasks.workspace_id
75+
ANDworkspace_build.build_number=task_app.workspace_build_number
76+
) latest_build_rawON TRUE
77+
LEFT JOIN LATERAL (
78+
SELECT
79+
workspace_agent.lifecycle_state
80+
FROM
81+
workspace_agents workspace_agent
82+
WHERE
83+
workspace_agent.id=task_app.workspace_agent_id
84+
) agent_rawON TRUE
85+
LEFT JOIN LATERAL (
86+
SELECT
87+
workspace_app.health
88+
FROM
89+
workspace_apps workspace_app
90+
WHERE
91+
workspace_app.id=task_app.workspace_app_id
92+
) app_rawON TRUE
93+
94+
-- Compute the status for each component.
95+
CROSS JOIN LATERAL (
96+
SELECT
97+
CASE
98+
WHENlatest_build_raw.job_status ISNULL THEN'pending'::task_status
99+
WHENlatest_build_raw.job_statusIN ('failed','canceling','canceled') THEN'error'::task_status
100+
WHEN
101+
latest_build_raw.transitionIN ('stop','delete')
102+
ANDlatest_build_raw.job_status='succeeded' THEN'paused'::task_status
103+
WHEN
104+
latest_build_raw.transition='start'
105+
ANDlatest_build_raw.job_status='pending' THEN'initializing'::task_status
106+
-- Build is running or done, defer to agent/app status.
107+
WHEN
108+
latest_build_raw.transition='start'
109+
ANDlatest_build_raw.job_statusIN ('running','succeeded') THEN'active'::task_status
110+
ELSE'unknown'::task_status
111+
ENDAS status
112+
) build_status
113+
CROSS JOIN LATERAL (
114+
SELECT
115+
CASE
116+
-- No agent or connecting.
117+
WHEN
118+
agent_raw.lifecycle_state ISNULL
119+
ORagent_raw.lifecycle_stateIN ('created','starting') THEN'initializing'::task_status
120+
-- Agent is running, defer to app status.
121+
-- NOTE(mafredri): The start_error/start_timeout states means connected, but some startup script failed.
122+
-- This may or may not affect the task status but this has to be caught by app health check.
123+
WHENagent_raw.lifecycle_stateIN ('ready','start_timeout','start_error') THEN'active'::task_status
124+
-- If the agent is shutting down or turned off, this is an unknown state because we would expect a stop
125+
-- build to be running.
126+
-- This is essentially equal to: `IN ('shutting_down', 'shutdown_timeout', 'shutdown_error', 'off')`,
127+
-- but we cannot use them because the values were added in a migration.
128+
WHENagent_raw.lifecycle_state NOTIN ('created','starting','ready','start_timeout','start_error') THEN'unknown'::task_status
129+
ELSE'unknown'::task_status
130+
ENDAS status
131+
) agent_status
132+
CROSS JOIN LATERAL (
133+
SELECT
134+
CASE
135+
WHENapp_raw.health='initializing' THEN'initializing'::task_status
136+
WHENapp_raw.health='unhealthy' THEN'error'::task_status
137+
WHENapp_raw.healthIN ('healthy','disabled') THEN'active'::task_status
138+
ELSE'unknown'::task_status
139+
ENDAS status
140+
) app_status
141+
WHERE
142+
tasks.deleted_at ISNULL;

‎coderd/database/models.go‎

Lines changed: 20 additions & 17 deletions
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp