Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit144b1ed

Browse files
committed
fix: reduce size of terraform modules archive
1 parent5c77cdf commit144b1ed

File tree

6 files changed

+340
-286
lines changed

6 files changed

+340
-286
lines changed

‎provisioner/terraform/modules.go‎

Lines changed: 67 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,8 @@ type modulesFile struct {
2424
Modules []*module`json:"Modules"`
2525
}
2626

27-
funcgetModulesDirectory(workdirstring)string {
28-
returnfilepath.Join(workdir,".terraform","modules")
29-
}
30-
3127
funcgetModulesFilePath(workdirstring)string {
32-
returnfilepath.Join(getModulesDirectory(workdir),"modules.json")
28+
returnfilepath.Join(workdir,".terraform","modules","modules.json")
3329
}
3430

3531
funcparseModulesFile(filePathstring) ([]*proto.Module,error) {
@@ -72,52 +68,83 @@ func getModules(workdir string) ([]*proto.Module, error) {
7268
}
7369

7470
funcgetModulesArchive(workdirstring) ([]byte,error) {
75-
modulesDir:=getModulesDirectory(workdir)
76-
if_,err:=os.ReadDir(modulesDir);err!=nil {
71+
modulesFile,err:=os.ReadFile(getModulesFilePath(workdir))
72+
iferr!=nil {
7773
ifos.IsNotExist(err) {
7874
return []byte{},nil
7975
}
80-
81-
returnnil,err
76+
returnnil,xerrors.Errorf("failed to read modules.json: %w",err)
8277
}
78+
varmstruct{Modules []*proto.Module }
79+
err=json.Unmarshal(modulesFile,&m)
80+
iferr!=nil {
81+
returnnil,xerrors.Errorf("failed to parse modules.json: %w",err)
82+
}
83+
8384
empty:=true
8485
varb bytes.Buffer
8586
w:=tar.NewWriter(&b)
86-
err:=filepath.WalkDir(modulesDir,func(filePathstring,info fs.DirEntry,errerror)error {
87-
iferr!=nil {
88-
returnxerrors.Errorf("failed to create modules archive: %w",err)
89-
}
90-
ifinfo.IsDir() {
91-
returnnil
92-
}
93-
archivePath,found:=strings.CutPrefix(filePath,workdir+string(os.PathSeparator))
94-
if!found {
95-
returnxerrors.Errorf("walked invalid file path: %q",filePath)
96-
}
9787

98-
content,err:=os.ReadFile(filePath)
99-
iferr!=nil {
100-
returnxerrors.Errorf("failed to read module file while archiving: %w",err)
88+
for_,module:=rangem.Modules {
89+
// Check to make sure that the module is a remote module fetched by
90+
// Terraform. Any module that doesn't start with this path is already local,
91+
// and should be part of the template files already.
92+
if!strings.HasPrefix(module.Dir,".terraform/modules/") {
93+
continue
10194
}
102-
empty=false
103-
err=w.WriteHeader(&tar.Header{
104-
Name:archivePath,
105-
Size:int64(len(content)),
106-
Mode:0o644,
107-
Uid:1000,
108-
Gid:1000,
95+
96+
err:=filepath.WalkDir(filepath.Join(workdir,module.Dir),func(filePathstring,info fs.DirEntry,errerror)error {
97+
iferr!=nil {
98+
returnxerrors.Errorf("failed to create modules archive: %w",err)
99+
}
100+
ifinfo.IsDir() {
101+
returnnil
102+
}
103+
archivePath,found:=strings.CutPrefix(filePath,workdir+string(os.PathSeparator))
104+
if!found {
105+
returnxerrors.Errorf("walked invalid file path: %q",filePath)
106+
}
107+
108+
content,err:=os.ReadFile(filePath)
109+
iferr!=nil {
110+
returnxerrors.Errorf("failed to read module file while archiving: %w",err)
111+
}
112+
empty=false
113+
err=w.WriteHeader(&tar.Header{
114+
Name:archivePath,
115+
Size:int64(len(content)),
116+
Mode:0o644,
117+
Uid:1000,
118+
Gid:1000,
119+
})
120+
iferr!=nil {
121+
returnxerrors.Errorf("failed to add module file to archive: %w",err)
122+
}
123+
if_,err=w.Write(content);err!=nil {
124+
returnxerrors.Errorf("failed to write module file to archive: %w",err)
125+
}
126+
returnnil
109127
})
110128
iferr!=nil {
111-
returnxerrors.Errorf("failed to add module file to archive: %w",err)
112-
}
113-
if_,err=w.Write(content);err!=nil {
114-
returnxerrors.Errorf("failed to write module file to archive: %w",err)
129+
returnnil,err
115130
}
116-
returnnil
131+
}
132+
133+
err=w.WriteHeader(&tar.Header{
134+
Name:".terraform/modules/modules.json",
135+
Size:int64(len(modulesFile)),
136+
Mode:0o644,
137+
Uid:1000,
138+
Gid:1000,
117139
})
118140
iferr!=nil {
119-
returnnil,err
141+
returnnil,xerrors.Errorf("failed to write modules.json to archive: %w",err)
142+
}
143+
_,err=w.Write(modulesFile)
144+
iferr!=nil {
145+
returnnil,xerrors.Errorf("failed to write modules.json to archive: %w",err)
120146
}
147+
121148
err=w.Close()
122149
iferr!=nil {
123150
returnnil,xerrors.Errorf("failed to close module files archive: %w",err)
@@ -126,5 +153,9 @@ func getModulesArchive(workdir string) ([]byte, error) {
126153
ifempty {
127154
return []byte{},nil
128155
}
156+
157+
ifb.Len()> (10<<20) {
158+
returnnil,xerrors.New("modules archive exceeds 10MB, modules will not be persisted")
159+
}
129160
returnb.Bytes(),nil
130161
}

‎provisioner/terraform/modules_internal_test.go‎

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,14 @@ func TestGetModulesArchive(t *testing.T) {
2525
require.NoError(t,err)
2626

2727
// Check that all of the files it should contain are correct
28-
r:=bytes.NewBuffer(archive)
29-
tarfs:=archivefs.FromTarReader(r)
30-
content,err:=fs.ReadFile(tarfs,".terraform/modules/example_module/main.tf")
28+
b:=bytes.NewBuffer(archive)
29+
tarfs:=archivefs.FromTarReader(b)
30+
31+
content,err:=fs.ReadFile(tarfs,".terraform/modules/modules.json")
32+
require.NoError(t,err)
33+
require.True(t,strings.HasPrefix(string(content),`{"Modules":[{"Key":"","Source":"","Dir":"."},`))
34+
35+
content,err=fs.ReadFile(tarfs,".terraform/modules/example_module/main.tf")
3136
require.NoError(t,err)
3237
require.True(t,strings.HasPrefix(string(content),"terraform {"))
3338
ifruntime.GOOS!="windows" {
@@ -36,6 +41,9 @@ func TestGetModulesArchive(t *testing.T) {
3641
require.Len(t,content,3812)
3742
}
3843

44+
_,err=fs.ReadFile(tarfs,".terraform/modules/stuff_that_should_not_be_included/nothing.txt")
45+
require.Error(t,err)
46+
3947
// It should always be byte-identical to optimize storage
4048
hashBytes:=sha256.Sum256(archive)
4149
hash:=hex.EncodeToString(hashBytes[:])
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
ここには何もありません

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp