Commit13beb04

authored

fix: disable keepalives in workspaceapps transport (#11789)

Connection caching causes requests to hit the wrong workspaces. Seecomment.Fixes#11767

1 parent1e2634d commit13beb04Copy full SHA for 13beb04

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -347,7 +347,7 @@ func (c DeviceAuth) AuthorizeDevice(ctx context.Context) (codersdk.ExternalAut`
`347`	`347`	`casemediaType=="application/x-www-form-urlencoded":`
`348`	`348`	`returnnil,xerrors.Errorf("status_code=%d, payload response is form-url encoded, expected a json payload",resp.StatusCode)`
`349`	`349`	`default:`
`350`		`-returnnil,fmt.Errorf("status_code=%d, mediaType=%s: %w",resp.StatusCode,mediaType,err)`
	`350`	`+returnnil,xerrors.Errorf("status_code=%d, mediaType=%s: %w",resp.StatusCode,mediaType,err)`
`351`	`351`	`}`
`352`	`352`	`}`
`353`	`353`	`ifr.ErrorDescription!="" {`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,14 @@ func NewServerTailnet(`
`103`	`103`	`transport:tailnetTransport.Clone(),`
`104`	`104`	`}`
`105`	`105`	`tn.transport.DialContext=tn.dialContext`
`106`		`-tn.transport.MaxIdleConnsPerHost=10`
	`106`	`+`
	`107`	`+// Bugfix: for some reason all calls to tn.dialContext come from`
	`108`	`+// "localhost", causing connections to be cached and requests to go to the`
	`109`	`+// wrong workspaces. This disables keepalives for now until the root cause`
	`110`	`+// can be found.`
	`111`	`+tn.transport.MaxIdleConnsPerHost=-1`
	`112`	`+tn.transport.DisableKeepAlives=true`
	`113`	`+`
`107`	`114`	`tn.transport.MaxIdleConns=0`
`108`	`115`	`// We intentionally don't verify the certificate chain here.`
`109`	`116`	`// The connection to the workspace is already established and most`

Comments

(0)