Commit139f004

committed

Check that required query params are non-zero

1 parentdede350 commit139f004Copy full SHA for 139f004

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -246,7 +246,7 @@ func ParseCustomList[T any](parser *QueryParamParser, vals url.Values, def []T,`
`246`	`246`	`funcparseQueryParam[Tany](parser*QueryParamParser,vals url.Values,parsefunc(vstring) (T,error),defT,queryParamstring) (T,error) {`
`247`	`247`	`parser.addParsed(queryParam)`
`248`	`248`	`// If the query param is required and not present, return an error.`
`249`		`-ifparser.RequiredParams[queryParam]&& (!vals.Has(queryParam)) {`
	`249`	`+ifparser.RequiredParams[queryParam]&& (!vals.Has(queryParam)\|\|vals.Get(queryParam)=="") {`
`250`	`250`	`parser.Errors=append(parser.Errors, codersdk.ValidationError{`
`251`	`251`	`Field:queryParam,`
`252`	`252`	`Detail:fmt.Sprintf("Query param %q is required",queryParam),`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -323,6 +323,11 @@ func TestParseQueryParams(t *testing.T) {`
`323`	`323`	`parser.Required("test_value")`
`324`	`324`	`parser.UUID(url.Values{},uuid.New(),"test_value")`
`325`	`325`	`require.Len(t,parser.Errors,1)`
	`326`	`+`
	`327`	`+parser=httpapi.NewQueryParamParser()`
	`328`	`+parser.Required("test_value")`
	`329`	`+parser.String(url.Values{"test_value": {""}},"","test_value")`
	`330`	`+require.Len(t,parser.Errors,1)`
`326`	`331`	`})`
`327`	`332`	`}`
`328`	`333`

Comments

(0)