NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

Commit12a9d63

authored

fix(agent): start rpty lifecycle after all reads/writes (#15535)

Fixescoder/internal#214 #15475 missed that we also write to `rpty` after starting`rpty.lifecycle()`.This PR moves the function call right at the end. Hopefully this shouldaddress the data races before we go resorting to mutexes.

1 parentaca5be5 commit12a9d63Copy full SHA for 12a9d63

File tree

1 file changed

-2

lines changed

agent/reconnectingpty
- screen.go

1 file changed

-2

lines changed

`‎agent/reconnectingpty/screen.go`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -78,8 +78,6 @@ func newScreen(ctx context.Context, cmd pty.Cmd, options Options, logger slog.`
`78`	`78`	`}`
`79`	`79`	`rpty.id=hex.EncodeToString(buf)`
`80`	`80`
`81`		`-gorpty.lifecycle(ctx,logger)`
`82`		`-`
`83`	`81`	`settings:= []string{`
`84`	`82`	`// Disable the startup message that appears for five seconds.`
`85`	`83`	`"startup_message off",`
`@@ -124,6 +122,8 @@ func newScreen(ctx context.Context, cmd pty.Cmd, options Options, logger slog.`
`124`	`122`	`returnrpty`
`125`	`123`	`}`
`126`	`124`
	`125`	`+gorpty.lifecycle(ctx,logger)`
	`126`	`+`
`127`	`127`	`returnrpty`
`128`	`128`	`}`
`129`	`129`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit12a9d63

File tree

1 file changed

1 file changed

`‎agent/reconnectingpty/screen.go`

0 commit comments