Commit127e7e5

committed

fix: add branch for Shared value in aRequestOption

1 parentdd758d3 commit127e7e5Copy full SHA for 127e7e5

File tree

+10

-7

lines changed

+10

-7

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1844,7 +1844,7 @@ func TestWorkspaceFilter(t *testing.T) {`
`1844`	`1844`	`})`
`1845`	`1845`
`1846`	`1846`	`workspaces,err:=client.Workspaces(ctx, codersdk.WorkspaceFilter{`
`1847`		`-Shared:true,`
	`1847`	`+Shared:ptr.Ref(true),`
`1848`	`1848`	`})`
`1849`	`1849`	`require.NoError(t,err,"fetch workspaces")`
`1850`	`1850`	`require.Equal(t,1,workspaces.Count,"expected only one workspace")`
`@@ -1882,7 +1882,7 @@ func TestWorkspaceFilter(t *testing.T) {`
`1882`	`1882`	`})`
`1883`	`1883`
`1884`	`1884`	`workspaces,err:=client.Workspaces(ctx, codersdk.WorkspaceFilter{`
`1885`		`-Shared:false,`
	`1885`	`+Shared:ptr.Ref(false),`
`1886`	`1886`	`})`
`1887`	`1887`	`require.NoError(t,err,"fetch workspaces")`
`1888`	`1888`	`require.Equal(t,1,workspaces.Count,"expected only one workspace")`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -516,10 +516,10 @@ type WorkspaceFilter struct {`
`516`	`516`	Offsetint`json:"offset,omitempty" typescript:"-"`
`517`	`517`	`// Limit is a limit on the number of workspaces returned.`
`518`	`518`	Limitint`json:"limit,omitempty" typescript:"-"`
	`519`	`+// Shared is a whether the workspace is shared with any users or groups`
	`520`	+Shared*bool`json:"shared,omitempty" typescript:"-"`
`519`	`521`	`// FilterQuery supports a raw filter query string`
`520`	`522`	FilterQuerystring`json:"q,omitempty"`
`521`		`-// Shared is a whether the workspace is shared with any users or groups`
`522`		-Sharedbool`json:"shared" typescript:"-"`
`523`	`523`	`}`
`524`	`524`
`525`	`525`	`// asRequestOption returns a function that can be used in (*Client).Request.`
`@@ -541,6 +541,9 @@ func (f WorkspaceFilter) asRequestOption() RequestOption {`
`541`	`541`	`iff.Status!="" {`
`542`	`542`	`params=append(params,fmt.Sprintf("status:%q",f.Status))`
`543`	`543`	`}`
	`544`	`+iff.Shared!=nil {`
	`545`	`+params=append(params,fmt.Sprintf("shared:%v",*f.Shared))`
	`546`	`+}`
`544`	`547`	`iff.FilterQuery!="" {`
`545`	`548`	`// If custom stuff is added, just add it on here.`
`546`	`549`	`params=append(params,f.FilterQuery)`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -3617,7 +3617,7 @@ func TestWorkspacesFiltering(t *testing.T) {`
`3617`	`3617`	`})`
`3618`	`3618`
`3619`	`3619`	`workspaces,err:=client.Workspaces(ctx, codersdk.WorkspaceFilter{`
`3620`		`-Shared:true,`
	`3620`	`+Shared:ptr.Ref(true),`
`3621`	`3621`	`})`
`3622`	`3622`	`require.NoError(t,err,"fetch workspaces")`
`3623`	`3623`	`require.Equal(t,1,workspaces.Count,"expected only one workspace")`
`@@ -3669,7 +3669,7 @@ func TestWorkspacesFiltering(t *testing.T) {`
`3669`	`3669`	`})`
`3670`	`3670`
`3671`	`3671`	`workspaces,err:=client.Workspaces(ctx, codersdk.WorkspaceFilter{`
`3672`		`-Shared:true,`
	`3672`	`+Shared:ptr.Ref(true),`
`3673`	`3673`	`})`
`3674`	`3674`	`require.NoError(t,err,"fetch workspaces")`
`3675`	`3675`	`require.Equal(t,1,workspaces.Count,"expected only one workspace")`
`@@ -3717,7 +3717,7 @@ func TestWorkspacesFiltering(t *testing.T) {`
`3717`	`3717`	`})`
`3718`	`3718`
`3719`	`3719`	`workspaces,err:=client.Workspaces(ctx, codersdk.WorkspaceFilter{`
`3720`		`-Shared:false,`
	`3720`	`+Shared:ptr.Ref(false),`
`3721`	`3721`	`})`
`3722`	`3722`	`require.NoError(t,err,"fetch workspaces")`
`3723`	`3723`	`require.Equal(t,1,workspaces.Count,"expected only one workspace")`

Comments

(0)